Re: [Qemu-devel] [PATCH 5/6] Makefile.objs: Remove libqemu_common.a target

2011-11-08 Thread 陳韋任
> > $(filter %-softmmu,$(SUBDIR_RULES)): $(trace-obj-y) $(common-obj-y) > > subdir-libdis > > > > I guess you ran into trouble while building *-softmmu? I think we can > > just remove "libqemu_common.a:" from the comment of common-obj-y and > > leave the rest part alone. > > Yes, please. I bel

Re: [Qemu-devel] [PATCH 5/6] Makefile.objs: Remove libqemu_common.a target

2011-11-08 Thread Andreas Färber
Am 08.11.2011 18:08, schrieb 陳韋任: >> Have you build this? without this files qemu is not going to work. >> Perhaps the naming is wrong, and we should change common-obj to >> something else, but it is still needed to get things working as >> expected. > > I found the line below in Makefile, > >

Re: [Qemu-devel] [PATCH 5/6] Makefile.objs: Remove libqemu_common.a target

2011-11-08 Thread Juan Quintela
陳韋任 wrote: >> Have you build this? without this files qemu is not going to work. >> Perhaps the naming is wrong, and we should change common-obj to >> something else, but it is still needed to get things working as >> expected. > > I found the line below in Makefile, > > $(filter %-softmmu,$(SU

Re: [Qemu-devel] [PATCH 5/6] Makefile.objs: Remove libqemu_common.a target

2011-11-08 Thread 陳韋任
> Have you build this? without this files qemu is not going to work. > Perhaps the naming is wrong, and we should change common-obj to > something else, but it is still needed to get things working as > expected. I found the line below in Makefile, $(filter %-softmmu,$(SUBDIR_RULES)): $(trace-

Re: [Qemu-devel] [PATCH 5/6] Makefile.objs: Remove libqemu_common.a target

2011-11-08 Thread 陳韋任
> Have you build this? without this files qemu is not going to work. > Perhaps the naming is wrong, and we should change common-obj to > something else, but it is still needed to get things working as > expected. Sorry, I have only tested i386-linux-user when I sent the patch. And i386-softmmu

Re: [Qemu-devel] [PATCH 5/6] Makefile.objs: Remove libqemu_common.a target

2011-11-08 Thread Juan Quintela
"Chen Wei-Ren (陳韋任)" wrote: > From: Chen Wen-Ren > > Remove libqemu_common.a target from Makefile.objs. Have you build this? without this files qemu is not going to work. Perhaps the naming is wrong, and we should change common-obj to something else, but it is still needed to get things worki

[Qemu-devel] [PATCH 5/6] Makefile.objs: Remove libqemu_common.a target

2011-11-08 Thread 陳韋任
From: Chen Wen-Ren Remove libqemu_common.a target from Makefile.objs. Signed-off-by: Chen Wei-Ren --- Makefile.objs | 104 - 1 files changed, 0 insertions(+), 104 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index d7a6539..