Re: [Qemu-devel] [PATCH 5/6] add visitor for parsing hz[KMG] input string

2012-12-06 Thread Igor Mammedov
On Wed, 5 Dec 2012 15:00:59 -0600 mdroth wrote: > On Wed, Dec 05, 2012 at 05:21:50PM -0200, Eduardo Habkost wrote: > > On Wed, Dec 05, 2012 at 11:52:29AM -0600, mdroth wrote: > > > On Tue, Dec 04, 2012 at 05:34:42PM -0200, Eduardo Habkost wrote: > > [...] > > > > diff --git a/qapi/string-input-vi

Re: [Qemu-devel] [PATCH 5/6] add visitor for parsing hz[KMG] input string

2012-12-05 Thread mdroth
On Wed, Dec 05, 2012 at 05:21:50PM -0200, Eduardo Habkost wrote: > On Wed, Dec 05, 2012 at 11:52:29AM -0600, mdroth wrote: > > On Tue, Dec 04, 2012 at 05:34:42PM -0200, Eduardo Habkost wrote: > [...] > > > diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c > > > index 497eb9a..7

Re: [Qemu-devel] [PATCH 5/6] add visitor for parsing hz[KMG] input string

2012-12-05 Thread Eduardo Habkost
On Wed, Dec 05, 2012 at 11:52:29AM -0600, mdroth wrote: > On Tue, Dec 04, 2012 at 05:34:42PM -0200, Eduardo Habkost wrote: [...] > > diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c > > index 497eb9a..74fe395 100644 > > --- a/qapi/string-input-visitor.c > > +++ b/qapi/string-i

Re: [Qemu-devel] [PATCH 5/6] add visitor for parsing hz[KMG] input string

2012-12-05 Thread mdroth
On Tue, Dec 04, 2012 at 05:34:42PM -0200, Eduardo Habkost wrote: > From: Igor Mammedov > > Signed-off-by: Igor Mammedov > Acked-by: Andreas Färber > --- > qapi/qapi-visit-core.c | 11 +++ > qapi/qapi-visit-core.h | 2 ++ > qapi/string-input-visitor.c | 22 +++

Re: [Qemu-devel] [PATCH 5/6] add visitor for parsing hz[KMG] input string

2012-12-04 Thread Andreas Färber
Am 04.12.2012 20:34, schrieb Eduardo Habkost: > From: Igor Mammedov > > Signed-off-by: Igor Mammedov > Acked-by: Andreas Färber Mike, do we need to do anything here wrt deallocation visitors? Or can you ack? Thanks, Andreas > --- > qapi/qapi-visit-core.c | 11 +++ > qapi/qapi-v

Re: [Qemu-devel] [PATCH 5/6] add visitor for parsing hz[KMG] input string

2012-12-04 Thread Eduardo Habkost
On Tue, Dec 04, 2012 at 05:34:42PM -0200, Eduardo Habkost wrote: > From: Igor Mammedov > > Signed-off-by: Igor Mammedov > Acked-by: Andreas Färber Reviewed-by: Eduardo Habkost > --- > qapi/qapi-visit-core.c | 11 +++ > qapi/qapi-visit-core.h | 2 ++ > qapi/string-input-v

[Qemu-devel] [PATCH 5/6] add visitor for parsing hz[KMG] input string

2012-12-04 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov Acked-by: Andreas Färber --- qapi/qapi-visit-core.c | 11 +++ qapi/qapi-visit-core.h | 2 ++ qapi/string-input-visitor.c | 22 ++ 3 files changed, 35 insertions(+) diff --git a/qapi/qapi-visit-core.c b/qap

[Qemu-devel] [PATCH 5/6] add visitor for parsing hz[KMG] input string

2012-12-04 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov Acked-by: Andreas Färber --- qapi/qapi-visit-core.c | 11 +++ qapi/qapi-visit-core.h | 2 ++ qapi/string-input-visitor.c | 22 ++ 3 files changed, 35 insertions(+) diff --git a/qapi/qapi-visit-core.c b/qap