Re: [Qemu-devel] [PATCH 5/6] fdc: use LOG_UNIMP logging

2012-06-11 Thread Kevin Wolf
Am 09.06.2012 14:12, schrieb Blue Swirl: > Convert uses of FLOPPY_ERROR to either FLOPPY_DPRINTF > (for implemented cases) or to use LOG_UNIMP (unimplemented). > > Signed-off-by: Blue Swirl Acked-by: Kevin Wolf

[Qemu-devel] [PATCH 5/6] fdc: use LOG_UNIMP logging

2012-06-09 Thread Blue Swirl
Convert uses of FLOPPY_ERROR to either FLOPPY_DPRINTF (for implemented cases) or to use LOG_UNIMP (unimplemented). Signed-off-by: Blue Swirl --- hw/fdc.c | 30 +- 1 files changed, 17 insertions(+), 13 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 30d34e3..662

Re: [Qemu-devel] [PATCH 5/6] fdc: use LOG_UNIMP logging

2012-06-08 Thread Kevin Wolf
Am 07.06.2012 23:07, schrieb Blue Swirl: > On Mon, Jun 4, 2012 at 9:36 AM, Kevin Wolf wrote: >> Am 03.06.2012 19:38, schrieb Blue Swirl: >>> Convert uses of FLOPPY_ERROR to either FLOPPY_DPRINTF >>> (for implemented cases) or to use LOG_UNIMP (unimplemented). >>> >>> Signed-off-by: Blue Swirl >>

Re: [Qemu-devel] [PATCH 5/6] fdc: use LOG_UNIMP logging

2012-06-07 Thread Blue Swirl
On Mon, Jun 4, 2012 at 9:36 AM, Kevin Wolf wrote: > Am 03.06.2012 19:38, schrieb Blue Swirl: >> Convert uses of FLOPPY_ERROR to either FLOPPY_DPRINTF >> (for implemented cases) or to use LOG_UNIMP (unimplemented). >> >> Signed-off-by: Blue Swirl > > I would suggest that you check the messages of

Re: [Qemu-devel] [PATCH 5/6] fdc: use LOG_UNIMP logging

2012-06-04 Thread Kevin Wolf
Am 03.06.2012 19:38, schrieb Blue Swirl: > Convert uses of FLOPPY_ERROR to either FLOPPY_DPRINTF > (for implemented cases) or to use LOG_UNIMP (unimplemented). > > Signed-off-by: Blue Swirl I would suggest that you check the messages of those cases that became FLOPPY_DPRINTF(). Originally the ma

[Qemu-devel] [PATCH 5/6] fdc: use LOG_UNIMP logging

2012-06-03 Thread Blue Swirl
Convert uses of FLOPPY_ERROR to either FLOPPY_DPRINTF (for implemented cases) or to use LOG_UNIMP (unimplemented). Signed-off-by: Blue Swirl --- hw/fdc.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 30d34e3..48803ec