On 03/18/15 21:06, Gabriel L. Somlo wrote:
> On Tue, Mar 17, 2015 at 12:49:50PM +0100, Gerd Hoffmann wrote:
[snip]
>> Which reminds me: Going for QemuOpts would be very useful (gives
>> -readconfig support), and it would solve the init order issue too.
>> Instead of having your custom storage yo
Hi,
> +case QEMU_OPTION_fwcfg:
> +opts = qemu_opts_parse(qemu_find_opts("fw_cfg"), optarg, 0);
> +if (opts == NULL) {
> +exit(1);
> +}
That is fine here.
> +fw_cfg_option_add(opts);
That should be
On Tue, Mar 17, 2015 at 12:28:20PM +0100, Laszlo Ersek wrote:
> > +
> > +void fw_cfg_option_add(QemuOpts *opts)
> > +{
> > +const char *name = qemu_opt_get(opts, "name");
> > +const char *file = qemu_opt_get(opts, "file");
> > +
> > +if (name == NULL || *name == '\0' || file == NULL ||
On Tue, Mar 17, 2015 at 12:49:50PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > Perhaps the suggestion to move the file loading from fw_cfg_init1() --
> > ie. device initialization -- to the earlier option parsing phase will
> > appease Gerd too :) But, admittedly, I don't know what the "existing
> >
Matt,
On Tue, Mar 17, 2015 at 10:55:30AM +, Matt Fleming wrote:
> > +void fw_cfg_option_add(QemuOpts *opts)
> > +{
> > +const char *name = qemu_opt_get(opts, "name");
> > +const char *file = qemu_opt_get(opts, "file");
> > +
> > +if (name == NULL || *name == '\0' || file == NULL ||
Hi,
> Perhaps the suggestion to move the file loading from fw_cfg_init1() --
> ie. device initialization -- to the earlier option parsing phase will
> appease Gerd too :) But, admittedly, I don't know what the "existing
> fw_cfg init order issues" that he referenced are.
Basically fw_cfg init p
comments below
On 03/16/15 15:15, Gabriel L. Somlo wrote:
> Allow user supplied files to be inserted into the fw_cfg
> device before starting the guest. Since fw_cfg_add_file()
> already disallows duplicate fw_cfg file names, qemu will
> exit with an error message if the user supplies multiple
> b
On Mon, 2015-03-16 at 10:15 -0400, Gabriel L. Somlo wrote:
> Allow user supplied files to be inserted into the fw_cfg
> device before starting the guest. Since fw_cfg_add_file()
> already disallows duplicate fw_cfg file names, qemu will
> exit with an error message if the user supplies multiple
> b
Hi,
> +static struct FWCfgOption {
> +const char *name;
> +const char *file;
> +} *fw_cfg_options;
> +static int fw_cfg_num_options;
> +void fw_cfg_option_add(QemuOpts *opts)
> +static void fw_cfg_options_insert(FWCfgState *s)
Hmm, when looking at this (and the existing fw_cfg init or
Allow user supplied files to be inserted into the fw_cfg
device before starting the guest. Since fw_cfg_add_file()
already disallows duplicate fw_cfg file names, qemu will
exit with an error message if the user supplies multiple
blobs with the same fw_cfg file name, or if a blob name
collides with
10 matches
Mail list logo
