Re: [Qemu-devel] [PATCH 5/6] qapi: extract CpuInfoCommon to mitigate schema duplication

Laszlo Ersek writes: > On 04/25/18 21:12, Eric Blake wrote: >> On 04/25/2018 08:20 AM, Laszlo Ersek wrote: >> >>> ... >>> >>> and people would ask themselves ever after, "are there some common >>> fields in there that we could extract ... hmmm, @props and @arch, okay, >>>

Re: [Qemu-devel] [PATCH 5/6] qapi: extract CpuInfoCommon to mitigate schema duplication

On 04/25/18 21:12, Eric Blake wrote: > On 04/25/2018 08:20 AM, Laszlo Ersek wrote: > >> ... >> >> and people would ask themselves ever after, "are there some common >> fields in there that we could extract ... hmmm, @props and @arch, okay, >> maybe, maybe not, grey area". Let's do it now and save

Re: [Qemu-devel] [PATCH 5/6] qapi: extract CpuInfoCommon to mitigate schema duplication

On 04/25/2018 08:20 AM, Laszlo Ersek wrote: > ... > > and people would ask themselves ever after, "are there some common > fields in there that we could extract ... hmmm, @props and @arch, okay, > maybe, maybe not, grey area". Let's do it now and save them the thinking. No, CpuInfo is slated

Re: [Qemu-devel] [PATCH 5/6] qapi: extract CpuInfoCommon to mitigate schema duplication

Laszlo Ersek writes: > On 04/25/18 09:06, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> @CpuInfo and @CpuInfoFast duplicate the following four fields: @qom-path, >>> @thread-id, @props and @arch. From these, extract the first three to a >>>

Re: [Qemu-devel] [PATCH 5/6] qapi: extract CpuInfoCommon to mitigate schema duplication

On 04/25/18 09:06, Markus Armbruster wrote: > Laszlo Ersek writes: > >> @CpuInfo and @CpuInfoFast duplicate the following four fields: @qom-path, >> @thread-id, @props and @arch. From these, extract the first three to a >> common structure called @CpuInfoCommon. (More on @arch

Re: [Qemu-devel] [PATCH 5/6] qapi: extract CpuInfoCommon to mitigate schema duplication

Laszlo Ersek writes: > @CpuInfo and @CpuInfoFast duplicate the following four fields: @qom-path, > @thread-id, @props and @arch. From these, extract the first three to a > common structure called @CpuInfoCommon. (More on @arch later.) > > Introduce two new mid-layer

[Qemu-devel] [PATCH 5/6] qapi: extract CpuInfoCommon to mitigate schema duplication

@CpuInfo and @CpuInfoFast duplicate the following four fields: @qom-path, @thread-id, @props and @arch. From these, extract the first three to a common structure called @CpuInfoCommon. (More on @arch later.) Introduce two new mid-layer structures, @CpuInfoBase and @CpuInfoFastBase, to soak up the