Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-04 Thread Paolo Bonzini
Il 04/10/2014 05:24, Corey Minyard ha scritto: Can you please add a follow-up patch that only prints this message once per reconnect? Otherwise a server that shuts down can spam logs forever. Yes, not a problem. I always wonder the best way to handle something like that, but you are

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-03 Thread Paolo Bonzini
Il 02/10/2014 18:17, miny...@acm.org ha scritto: +if (!qemu_chr_open_socket_fd(chr, err)) { +error_report(Unable to connect to char device %s\n, chr-label); +qemu_chr_socket_restart_timer(chr); +} Can you please add a follow-up patch that only prints this message once

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-03 Thread Corey Minyard
On 10/03/2014 05:22 PM, Paolo Bonzini wrote: Il 02/10/2014 18:17, miny...@acm.org ha scritto: +if (!qemu_chr_open_socket_fd(chr, err)) { +error_report(Unable to connect to char device %s\n, chr-label); +qemu_chr_socket_restart_timer(chr); +} Can you please add a

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-02 Thread Paolo Bonzini
Il 01/10/2014 23:09, miny...@acm.org ha scritto: From: Corey Minyard cminy...@mvista.com Adds a reconnect option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the connection, qemu will attempt to reconnect after

[Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-02 Thread minyard
From: Corey Minyard cminy...@mvista.com Adds a reconnect option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the connection, qemu will attempt to reconnect after the given number of seconds. Signed-off-by: Corey

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-01 Thread Corey Minyard
I haven't heard anything about these patches. Is there anything I need to do to get them included? Thanks, -corey On 09/25/2014 03:07 PM, miny...@acm.org wrote: From: Corey Minyard cminy...@mvista.com Adds a reconnect option to socket backends that gives a reconnect timeout. This only

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-01 Thread Paolo Bonzini
Il 01/10/2014 14:38, Corey Minyard ha scritto: I haven't heard anything about these patches. Is there anything I need to do to get them included? Nothing, I just missed them in the huge traffic of qemu-devel. Will look at them tomorrow. Thanks for pinging them. Paolo

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-01 Thread Eric Blake
On 09/25/2014 02:07 PM, miny...@acm.org wrote: From: Corey Minyard cminy...@mvista.com Adds a reconnect option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the connection, qemu will attempt to reconnect after

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-10-01 Thread Corey Minyard
On 10/01/2014 02:10 PM, Eric Blake wrote: On 09/25/2014 02:07 PM, miny...@acm.org wrote: From: Corey Minyard cminy...@mvista.com Adds a reconnect option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the

[Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-09-25 Thread minyard
From: Corey Minyard cminy...@mvista.com Adds a reconnect option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the connection, qemu will attempt to reconnect after the given number of seconds. Signed-off-by: Corey

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-09-22 Thread Paolo Bonzini
Il 22/09/2014 01:04, miny...@acm.org ha scritto: From: Corey Minyard cminy...@mvista.com Adds a reconnect option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the connection, qemu will attempt to reconnect after

[Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-09-22 Thread minyard
From: Corey Minyard cminy...@mvista.com Adds a reconnect option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the connection, qemu will attempt to reconnect after the given number of seconds. Signed-off-by: Corey

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-09-22 Thread Eric Blake
On 09/21/2014 05:04 PM, miny...@acm.org wrote: From: Corey Minyard cminy...@mvista.com Adds a reconnect option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the connection, qemu will attempt to reconnect after

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-09-22 Thread Eric Blake
On 09/22/2014 10:59 AM, miny...@acm.org wrote: From: Corey Minyard cminy...@mvista.com Adds a reconnect option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the connection, qemu will attempt to reconnect after

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-09-22 Thread Corey Minyard
On 09/22/2014 03:24 PM, Eric Blake wrote: On 09/21/2014 05:04 PM, miny...@acm.org wrote: From: Corey Minyard cminy...@mvista.com Adds a reconnect option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the

Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-09-22 Thread Eric Blake
On 09/22/2014 02:36 PM, Corey Minyard wrote: Hmm, thinking aloud here. What happens if 'reconnect' is provided with a 'server':true socket? The documentation only specifies 'server':false behavior. Should it be an error (incompatible options), or just be silently ignored? I was going on

[Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets

2014-09-21 Thread minyard
From: Corey Minyard cminy...@mvista.com Adds a reconnect option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the connection, qemu will attempt to reconnect after the given number of seconds. Signed-off-by: Corey