Re: [Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local storage in !user-mode

2018-09-11 Thread Emilio G. Cota
On Tue, Sep 11, 2018 at 13:24:03 +0200, Paolo Bonzini wrote: > On 10/09/2018 14:30, Emilio G. Cota wrote: > >> I'm confused - as we can have multi-threaded user space don't the same > >> requirements apply? > > In user-mode, code generation is serialized by mmap_lock. > > Making these per-thread wo

Re: [Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local storage in !user-mode

2018-09-11 Thread Paolo Bonzini
On 10/09/2018 14:30, Emilio G. Cota wrote: >> I'm confused - as we can have multi-threaded user space don't the same >> requirements apply? > In user-mode, code generation is serialized by mmap_lock. > Making these per-thread would just waste TLS space. It's stupid question time! How can the TLS

Re: [Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local storage in !user-mode

2018-09-10 Thread Alex Bennée
Emilio G. Cota writes: > On Mon, Sep 10, 2018 at 10:17:53 +0100, Alex Bennée wrote: >> >> Emilio G. Cota writes: >> >> > Needed for MTTCG. >> > >> > Signed-off-by: Emilio G. Cota >> > --- >> > target/i386/translate.c | 24 >> > 1 file changed, 16 insertions(+), 8 del

Re: [Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local storage in !user-mode

2018-09-10 Thread Emilio G. Cota
On Mon, Sep 10, 2018 at 10:17:53 +0100, Alex Bennée wrote: > > Emilio G. Cota writes: > > > Needed for MTTCG. > > > > Signed-off-by: Emilio G. Cota > > --- > > target/i386/translate.c | 24 > > 1 file changed, 16 insertions(+), 8 deletions(-) > > > > diff --git a/targe

Re: [Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local storage in !user-mode

2018-09-10 Thread Alex Bennée
Emilio G. Cota writes: > Needed for MTTCG. > > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 24 > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/target/i386/translate.c b/target/i386/translate.c > index 1f9d1d9b24..9a6a72e205 1006

[Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local storage in !user-mode

2018-09-03 Thread Emilio G. Cota
Needed for MTTCG. Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index 1f9d1d9b24..9a6a72e205 100644 --- a/target/i386/translate.c +++ b/targ