[Qemu-devel] [PATCH 5/6] target-alpha: Fix cpu_alpha_init

2012-09-21 Thread Richard Henderson
The cpu_model string must be stored for use during clone. Signed-off-by: Richard Henderson --- target-alpha/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index 12de6a3..93063fb 100644 --- a/target-alpha/translate.c +++ b/targe

Re: [Qemu-devel] [PATCH 5/6] target-alpha: Fix cpu_alpha_init

2012-09-16 Thread Richard Henderson
On 2012-09-16 11:00, Andreas Färber wrote: > As for the reentrancy of the translation initialization, I would prefer > that being handled in initfn, but we can first introduce it here and > move it later. Sure. I was monkey copying the arm cpu_init for that. > So, if you suggest a wording for th

Re: [Qemu-devel] [PATCH 5/6] target-alpha: Fix cpu_alpha_init

2012-09-16 Thread Andreas Färber
Am 16.09.2012 18:56, schrieb Richard Henderson: > On 2012-09-16 06:01, Andreas Färber wrote: >> This is lacking a proper description. I'd be very ashamed if we lost >> something so obvious during the QOM conversion. So what's the symptoms here? > > The most important thing here is saving cpu_model

Re: [Qemu-devel] [PATCH 5/6] target-alpha: Fix cpu_alpha_init

2012-09-16 Thread Richard Henderson
On 2012-09-16 06:01, Andreas Färber wrote: > This is lacking a proper description. I'd be very ashamed if we lost > something so obvious during the QOM conversion. So what's the symptoms here? The most important thing here is saving cpu_model_str. The symptom being a SEGV on clone, when cpu_model_

Re: [Qemu-devel] [PATCH 5/6] target-alpha: Fix cpu_alpha_init

2012-09-16 Thread Andreas Färber
Am 15.09.2012 22:24, schrieb Richard Henderson: > Signed-off-by: Richard Henderson This is lacking a proper description. I'd be very ashamed if we lost something so obvious during the QOM conversion. So what's the symptoms here? Andreas > --- > target-alpha/translate.c | 7 ++- > 1 file ch

[Qemu-devel] [PATCH 5/6] target-alpha: Fix cpu_alpha_init

2012-09-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-alpha/translate.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index 12de6a3..f998f75 100644 --- a/target-alpha/translate.c +++ b/target-alpha/translate.c @@ -3525,6 +3525,