Passing on '0' as ballooning target to indicate retrieval of stats is
bad API. It also makes 'balloon 0' in the monitor cause a segfault.
Have two different functions handle the different functionality instead.
Detailed explanation from Markus's review:
1. do_info_balloon() is an info_async() me
Amit Shah writes:
> On (Fri) 22 Jul 2011 [16:45:55], Markus Armbruster wrote:
>> Amit Shah writes:
>>
>> > Passing on '0' as ballooning target to indicate retrieval of stats is
>> > bad API. It also makes 'balloon 0' in the monitor cause a segfault.
>> > Have two different functions handle the
On (Fri) 22 Jul 2011 [16:45:55], Markus Armbruster wrote:
> Amit Shah writes:
>
> > Passing on '0' as ballooning target to indicate retrieval of stats is
> > bad API. It also makes 'balloon 0' in the monitor cause a segfault.
> > Have two different functions handle the different functionality in
Amit Shah writes:
> Passing on '0' as ballooning target to indicate retrieval of stats is
> bad API. It also makes 'balloon 0' in the monitor cause a segfault.
> Have two different functions handle the different functionality instead.
>
> Reported-by: Mike Cao
> Signed-off-by: Amit Shah
Can y
Passing on '0' as ballooning target to indicate retrieval of stats is
bad API. It also makes 'balloon 0' in the monitor cause a segfault.
Have two different functions handle the different functionality instead.
Reported-by: Mike Cao
Signed-off-by: Amit Shah
---
balloon.c | 17 +
