[Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Luiz Capitulino
The 'quit' Monitor command (implemented by do_quit()) calls exit() directly, this is problematic under QMP because QEMU exits before having a chance to send the ok response. Clients don't know if QEMU exited because of a problem or because the 'quit' command has been executed. This commit fixes t

Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Anthony Liguori
On 04/26/2010 10:47 AM, Luiz Capitulino wrote: The 'quit' Monitor command (implemented by do_quit()) calls exit() directly, this is problematic under QMP because QEMU exits before having a chance to send the ok response. Clients don't know if QEMU exited because of a problem or because the 'quit

Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Luiz Capitulino
On Mon, 26 Apr 2010 12:49:40 -0500 Anthony Liguori wrote: > On 04/26/2010 10:47 AM, Luiz Capitulino wrote: > > The 'quit' Monitor command (implemented by do_quit()) calls > > exit() directly, this is problematic under QMP because QEMU > > exits before having a chance to send the ok response. > >

Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Anthony Liguori
On 04/26/2010 01:22 PM, Luiz Capitulino wrote: On Mon, 26 Apr 2010 12:49:40 -0500 Anthony Liguori wrote: On 04/26/2010 10:47 AM, Luiz Capitulino wrote: The 'quit' Monitor command (implemented by do_quit()) calls exit() directly, this is problematic under QMP because QEMU exits befor

Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Luiz Capitulino
On Mon, 26 Apr 2010 13:25:38 -0500 Anthony Liguori wrote: > On 04/26/2010 01:22 PM, Luiz Capitulino wrote: > > On Mon, 26 Apr 2010 12:49:40 -0500 > > Anthony Liguori wrote: > > > > > >> On 04/26/2010 10:47 AM, Luiz Capitulino wrote: > >> > >>> The 'quit' Monitor command (implemented by

Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit'

2010-04-26 Thread Anthony Liguori
On 04/26/2010 01:53 PM, Luiz Capitulino wrote: On Mon, 26 Apr 2010 13:25:38 -0500 Anthony Liguori wrote: On 04/26/2010 01:22 PM, Luiz Capitulino wrote: On Mon, 26 Apr 2010 12:49:40 -0500 Anthony Liguori wrote: On 04/26/2010 10:47 AM, Luiz Capitulino wrote: T