Re: [Qemu-devel] [PATCH 5/9] nbd/client: fix error messages in nbd_handle_reply_err

16.02.2018 20:38, Eric Blake wrote: On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: 1. NBD_REP_ERR_INVALID is not only about length, so, make message more     general 2. hex format is not very good: it's hard to read something like     "option a (set meta context)", so switch to

Re: [Qemu-devel] [PATCH 5/9] nbd/client: fix error messages in nbd_handle_reply_err

On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: 1. NBD_REP_ERR_INVALID is not only about length, so, make message more general 2. hex format is not very good: it's hard to read something like "option a (set meta context)", so switch to dec. It would be okay as option 0xa;

[Qemu-devel] [PATCH 5/9] nbd/client: fix error messages in nbd_handle_reply_err

1. NBD_REP_ERR_INVALID is not only about length, so, make message more general 2. hex format is not very good: it's hard to read something like "option a (set meta context)", so switch to dec. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/client.c | 14