Re: [Qemu-devel] [PATCH 5/9] nvme: remove superfluous check

2014-11-17 Thread Stefan Hajnoczi
On Sat, Nov 15, 2014 at 06:06:44PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Operands don't affect result (CONSTANT_EXPRESSION_RESULT) > ((n->bar.aqa >> AQA_ASQS_SHIFT) & AQA_ASQS_MASK) > 4095 > is always false regardless of the values of its operands. > This occurs as the logical

[Qemu-devel] [PATCH 5/9] nvme: remove superfluous check

2014-11-15 Thread arei.gonglei
From: Gonglei Operands don't affect result (CONSTANT_EXPRESSION_RESULT) ((n->bar.aqa >> AQA_ASQS_SHIFT) & AQA_ASQS_MASK) > 4095 is always false regardless of the values of its operands. This occurs as the logical second operand of '||'. Signed-off-by: Gonglei --- hw/block/nvme.c | 3 +-- 1 fil