[Qemu-devel] [PATCH 6/6] hw/pc.c: Fix converting of ioport_register* to MemoryRegion

2013-01-11 Thread Stefan Hajnoczi
From: Julien Grall julien.gr...@citrix.com The commit 258711 introduced MemoryRegion to replace ioport_region* for ioport 80h and F0h. A MemoryRegion needs to have both read and write callback otherwise a segfault will occur when an access is made. The previous behaviour of this both ioport is

Re: [Qemu-devel] [PATCH 6/6] hw/pc.c: Fix converting of ioport_register* to MemoryRegion

2013-01-11 Thread Andreas Färber
Am 11.01.2013 10:18, schrieb Stefan Hajnoczi: From: Julien Grall julien.gr...@citrix.com The commit 258711 introduced MemoryRegion to replace ioport_region* for ioport 80h and F0h. A MemoryRegion needs to have both read and write callback otherwise a segfault will occur when an access is

Re: [Qemu-devel] [PATCH 6/6] hw/pc.c: Fix converting of ioport_register* to MemoryRegion

2013-01-11 Thread Julien Grall
On 01/11/2013 11:50 AM, Andreas Färber wrote: Am 11.01.2013 10:18, schrieb Stefan Hajnoczi: From: Julien Grall julien.gr...@citrix.com The commit 258711 introduced MemoryRegion to replace ioport_region* for ioport 80h and F0h. A MemoryRegion needs to have both read and write callback

Re: [Qemu-devel] [PATCH 6/6] hw/pc.c: Fix converting of ioport_register* to MemoryRegion

2013-01-11 Thread Julien Grall
From: Julien Grall julien.gr...@citrix.com The commit 258711 introduced MemoryRegion to replace ioport_region* for ioport 80h and F0h. A MemoryRegion needs to have both read and write callback otherwise a segfault will occur when an access is made. The previous behaviour of this both ioport is

Re: [Qemu-devel] [PATCH 6/6] hw/pc.c: Fix converting of ioport_register* to MemoryRegion

2013-01-11 Thread Andreas Färber
Am 11.01.2013 15:53, schrieb Julien Grall: On 01/11/2013 11:50 AM, Andreas Färber wrote: Am 11.01.2013 10:18, schrieb Stefan Hajnoczi: @@ -103,6 +103,11 @@ static void ioport80_write(void *opaque, hwaddr addr, uint64_t data, { } +static uint64_t ioport80_read(void *opaque, hwaddr