Peter Maydell writes:
> On 10 January 2011 15:50, Blue Swirl wrote:
>> On Mon, Jan 10, 2011 at 12:45 PM, Markus Armbruster
>> wrote:
>>> Covers all the obvious accesses except for a couple of s->eeprom[addr]
>>> in lan9118_eeprom_cmd(). addr is a parameter there, and the actual
>>> argument i
On 10 January 2011 15:50, Blue Swirl wrote:
> On Mon, Jan 10, 2011 at 12:45 PM, Markus Armbruster wrote:
>> Covers all the obvious accesses except for a couple of s->eeprom[addr]
>> in lan9118_eeprom_cmd(). addr is a parameter there, and the actual
>> argument is val & 0xff, in lan9118_writel().
On Mon, Jan 10, 2011 at 12:45 PM, Markus Armbruster wrote:
> Blue Swirl writes:
>
>> Fix a buffer overflow, reported by cppcheck:
>> [/src/qemu/hw/lan9118.c:849]: (error) Buffer access out-of-bounds: s.eeprom
>>
>> All eeprom handling code assumes that the size of eeprom is 128.
>>
>> Signed-off-
Blue Swirl writes:
> Fix a buffer overflow, reported by cppcheck:
> [/src/qemu/hw/lan9118.c:849]: (error) Buffer access out-of-bounds: s.eeprom
>
> All eeprom handling code assumes that the size of eeprom is 128.
>
> Signed-off-by: Blue Swirl
> ---
> hw/lan9118.c |2 +-
> 1 files changed, 1
Fix a buffer overflow, reported by cppcheck:
[/src/qemu/hw/lan9118.c:849]: (error) Buffer access out-of-bounds: s.eeprom
All eeprom handling code assumes that the size of eeprom is 128.
Signed-off-by: Blue Swirl
---
hw/lan9118.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff