Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-06 Thread Peter Maydell
On 6 May 2015 at 19:24, Richard Henderson wrote: > On 05/06/2015 08:44 AM, Peter Maydell wrote: >> This is making the assumption that what the disassembler sees as >> a "different mode" is the same as what the translator sees as a >> "different mode" for which it needs to end the TB... This happen

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-06 Thread Richard Henderson
On 05/06/2015 08:44 AM, Peter Maydell wrote: > On 6 May 2015 at 15:12, Richard Henderson wrote: >> On 05/06/2015 12:06 AM, Peter Crosthwaite wrote: >>> Can >>> we rely on the env/CPUState always being up to date during >>> target_disas (which happens at translate time?) or will we need to go >>> f

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-06 Thread Peter Maydell
On 6 May 2015 at 15:12, Richard Henderson wrote: > On 05/06/2015 12:06 AM, Peter Crosthwaite wrote: >> Can >> we rely on the env/CPUState always being up to date during >> target_disas (which happens at translate time?) or will we need to go >> field by field to make sure any env updates explicitl

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-06 Thread Stefano Stabellini
On Wed, 6 May 2015, Paolo Bonzini wrote: > On 06/05/2015 16:12, Richard Henderson wrote: > >> Can > >> > we rely on the env/CPUState always being up to date during > >> > target_disas (which happens at translate time?) or will we need to go > >> > field by field to make sure any env updates explici

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-06 Thread Richard Henderson
On 05/06/2015 12:06 AM, Peter Crosthwaite wrote: > Can > we rely on the env/CPUState always being up to date during > target_disas (which happens at translate time?) or will we need to go > field by field to make sure any env updates explicitly occur before > target_disas? I *think* so, but it's a

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-06 Thread Paolo Bonzini
On 06/05/2015 16:12, Richard Henderson wrote: >> Can >> > we rely on the env/CPUState always being up to date during >> > target_disas (which happens at translate time?) or will we need to go >> > field by field to make sure any env updates explicitly occur before >> > target_disas? > I *think* s

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-06 Thread Richard Henderson
On 05/05/2015 11:57 PM, Peter Crosthwaite wrote: > So I have made a start on this. The ARM, MB and CRIS in this patch > series is rather easy. Its X86 im having trouble with but your example > here looks like most of the work ... > >> Indeed, the flags setup becomes less obscure when, instead of >

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-06 Thread Peter Crosthwaite
On Tue, May 5, 2015 at 10:43 AM, Richard Henderson wrote: > On 05/05/2015 10:19 AM, Peter Maydell wrote: >> On 5 May 2015 at 05:45, Peter Crosthwaite wrote: >>> Add the ARM specific disassembly flags setup, so ARM can be correctly >>> disassembled from the monitor. >>> >>> Signed-off-by: Peter Cr

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-05 Thread Peter Crosthwaite
On Tue, May 5, 2015 at 10:43 AM, Richard Henderson wrote: > On 05/05/2015 10:19 AM, Peter Maydell wrote: >> On 5 May 2015 at 05:45, Peter Crosthwaite wrote: >>> Add the ARM specific disassembly flags setup, so ARM can be correctly >>> disassembled from the monitor. >>> >>> Signed-off-by: Peter Cr

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-05 Thread Richard Henderson
On 05/05/2015 10:19 AM, Peter Maydell wrote: > On 5 May 2015 at 05:45, Peter Crosthwaite wrote: >> Add the ARM specific disassembly flags setup, so ARM can be correctly >> disassembled from the monitor. >> >> Signed-off-by: Peter Crosthwaite >> --- >> monitor.c | 11 +++ >> 1 file change

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-05 Thread Peter Maydell
On 5 May 2015 at 05:45, Peter Crosthwaite wrote: > Add the ARM specific disassembly flags setup, so ARM can be correctly > disassembled from the monitor. > > Signed-off-by: Peter Crosthwaite > --- > monitor.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/monitor.c b/monit

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-05 Thread Claudio Fontana
On 05.05.2015 06:45, Peter Crosthwaite wrote: > Add the ARM specific disassembly flags setup, so ARM can be correctly > disassembled from the monitor. > > Signed-off-by: Peter Crosthwaite > --- > monitor.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/monitor.c b/monitor

[Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-04 Thread Peter Crosthwaite
Add the ARM specific disassembly flags setup, so ARM can be correctly disassembled from the monitor. Signed-off-by: Peter Crosthwaite --- monitor.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/monitor.c b/monitor.c index d831d98..9d9f1e2 100644 --- a/monitor.c +++ b/monitor.c