Re: [Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo

2015-04-01 Thread Fam Zheng
On Wed, 04/01 12:06, Alberto Garcia wrote: > On Wed, Apr 01, 2015 at 05:59:40PM +0800, Fam Zheng wrote: > > > > info->has_iops_size = cfg.op_size; > > > info->iops_size = cfg.op_size; > > > + > > > +info->has_group = true; > > > +info->group = g_strdup(throttle_gr

Re: [Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo

2015-04-01 Thread Alberto Garcia
On Wed, Apr 01, 2015 at 05:59:40PM +0800, Fam Zheng wrote: > > info->has_iops_size = cfg.op_size; > > info->iops_size = cfg.op_size; > > + > > +info->has_group = true; > > +info->group = g_strdup(throttle_group_get_name(bs)); > > True even if it's unset? Note th

Re: [Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo

2015-04-01 Thread Fam Zheng
On Mon, 03/30 19:19, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > block/qapi.c | 3 +++ > hmp.c| 6 -- > qapi/block-core.json | 4 +++- > 3 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/block/qapi.c b/block/qapi.c > index 65af057..e

[Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo

2015-03-30 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- block/qapi.c | 3 +++ hmp.c| 6 -- qapi/block-core.json | 4 +++- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index 65af057..ee823d1 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -91,6

[Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo

2015-03-30 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- block/qapi.c | 3 +++ hmp.c| 6 -- qapi/block-core.json | 4 +++- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index 65af057..ee823d1 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -91,6

[Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo

2015-03-26 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- block/qapi.c | 3 +++ hmp.c| 6 -- qapi/block-core.json | 4 +++- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index 65af057..ee823d1 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -91,6