Re: [Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file for windows.h

2014-02-25 Thread Paolo Bonzini
Il 25/02/2014 00:00, Stefan Weil ha scritto: Ah, thanks for explaining. I'll use the suggested name in an updated series. But you are aware that qga/ already includes sysemu/os-posix.h and sysemu/os-win32.h indirectly? Should those two files also be in include/qemu? No, but perhaps part of it s

Re: [Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file for windows.h

2014-02-24 Thread Stefan Weil
Am 24.02.2014 11:26, schrieb Paolo Bonzini: > Il 23/02/2014 18:02, Stefan Weil ha scritto: >> diff --git a/qga/channel-win32.c b/qga/channel-win32.c >> index 8a303f3..3a0bf13 100644 >> --- a/qga/channel-win32.c >> +++ b/qga/channel-win32.c >> @@ -2,7 +2,7 @@ >> #include >> #include >> #include

Re: [Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file for windows.h

2014-02-24 Thread Paolo Bonzini
Il 23/02/2014 18:02, Stefan Weil ha scritto: diff --git a/qga/channel-win32.c b/qga/channel-win32.c index 8a303f3..3a0bf13 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -2,7 +2,7 @@ #include #include #include -#include +#include "sysemu/os-winapi.h" #include #include #

[Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file for windows.h

2014-02-23 Thread Stefan Weil
Including windows.h from the new file include/sysemu/os-winapi.h allows better tracking of the files which depend on the Windows API. 1864 *.o files depend on windows.h in a typical build, only 88 *.o files don't. The windows.h specific macro WIN32_LEAN_AND_MEAN is now defined in the new file and