Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Gerd Hoffmann
On 10/12/12 13:17, Paolo Bonzini wrote: > Il 12/10/2012 13:15, Gerd Hoffmann ha scritto: In principle you're right, but I think it's ugly that adding another chardev argument needs changes in 3 places instead of just one. >> Hmm, I don't have to use the generated marshaller, right? With

Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Paolo Bonzini
Il 12/10/2012 13:15, Gerd Hoffmann ha scritto: >> > In principle you're right, but I think it's ugly that adding another >> > chardev argument needs changes in 3 places instead of just one. > Hmm, I don't have to use the generated marshaller, right? With direct > access to the QDict I could just t

Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Gerd Hoffmann
On 10/12/12 12:50, Paolo Bonzini wrote: > Il 12/10/2012 12:23, Gerd Hoffmann ha scritto: >>> I suggest that you implement the commands in a similar way as netdev_add. >> >> Why? Isn't the whole point of using josn is that you'll get the stuff >> from the josn parser & marshaller in a usable form i

Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Paolo Bonzini
Il 12/10/2012 12:23, Gerd Hoffmann ha scritto: >> I suggest that you implement the commands in a similar way as netdev_add. > > Why? Isn't the whole point of using josn is that you'll get the stuff > from the josn parser & marshaller in a usable form instead of having it > to feed into yet anothe

Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Gerd Hoffmann
On 10/12/12 11:40, Paolo Bonzini wrote: > Il 12/10/2012 11:26, Gerd Hoffmann ha scritto: >> This patch adds chardev_add and chardev_del monitor commands. >> >> chardev_del is pretty straight forward, it just takes an id argument and >> zaps the chardev specified. >> >> chardev_add is more tricky as

Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Paolo Bonzini
Il 12/10/2012 11:26, Gerd Hoffmann ha scritto: > This patch adds chardev_add and chardev_del monitor commands. > > chardev_del is pretty straight forward, it just takes an id argument and > zaps the chardev specified. > > chardev_add is more tricky as there are tons of arguments for the > differe

[Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

2012-10-12 Thread Gerd Hoffmann
This patch adds chardev_add and chardev_del monitor commands. chardev_del is pretty straight forward, it just takes an id argument and zaps the chardev specified. chardev_add is more tricky as there are tons of arguments for the different backends. The hmp version limited to the most common use