Re: [Qemu-devel] [PATCH 7/7] error: On abort, report where the error was created

2015-07-23 Thread Markus Armbruster
Eric Blake writes: > On 07/22/2015 07:54 AM, Markus Armbruster wrote: > >>> +#define error_setg(errp, fmt, ...) \ +error_setg_internal((errp), __FILE__, __LINE__, (fmt), ## __VA_ARGS__) +void error_setg_internal(Error **errp, const char *src, int line, +

Re: [Qemu-devel] [PATCH 7/7] error: On abort, report where the error was created

2015-07-22 Thread Eric Blake
On 07/22/2015 07:54 AM, Markus Armbruster wrote: >> >>> +#define error_setg(errp, fmt, ...) \ >>> +error_setg_internal((errp), __FILE__, __LINE__, (fmt), ## __VA_ARGS__) >>> +void error_setg_internal(Error **errp, const char *src, int line, >>> + const char *fmt, ...) G

Re: [Qemu-devel] [PATCH 7/7] error: On abort, report where the error was created

2015-07-22 Thread Markus Armbruster
Eric Blake writes: > On 06/22/2015 01:26 PM, Markus Armbruster wrote: >> This is particularly useful when we abort in error_propagate(), >> because there the stack backtrace doesn't lead to where the error was >> created. Looks like this: >> >> Unexpected error at /work/armbru/qemu/blockdev

Re: [Qemu-devel] [PATCH 7/7] error: On abort, report where the error was created

2015-07-21 Thread Eric Blake
On 06/22/2015 01:26 PM, Markus Armbruster wrote: > This is particularly useful when we abort in error_propagate(), > because there the stack backtrace doesn't lead to where the error was > created. Looks like this: > > Unexpected error at /work/armbru/qemu/blockdev.c:322: > qemu-system-x8

Re: [Qemu-devel] [PATCH 7/7] error: On abort, report where the error was created

2015-07-06 Thread Laszlo Ersek
On 06/22/15 21:26, Markus Armbruster wrote: > This is particularly useful when we abort in error_propagate(), > because there the stack backtrace doesn't lead to where the error was > created. Looks like this: > > Unexpected error at /work/armbru/qemu/blockdev.c:322: > qemu-system-x86_64:

[Qemu-devel] [PATCH 7/7] error: On abort, report where the error was created

2015-06-22 Thread Markus Armbruster
This is particularly useful when we abort in error_propagate(), because there the stack backtrace doesn't lead to where the error was created. Looks like this: Unexpected error at /work/armbru/qemu/blockdev.c:322: qemu-system-x86_64: -drive if=none,werror=foo: 'foo' invalid write error a