Re: [Qemu-devel] [PATCH 7/7] qcow2: Merge the writing of the COW regions with the guest data

2017-05-26 Thread Alberto Garcia
On Tue 23 May 2017 01:23:02 PM CEST, Alberto Garcia wrote: You can still review this now if you want, but here's a couple of minor things I'll correct in the next revision: > +if (m->data_qiov) { > +qemu_iovec_reset(&qiov); > +qemu_iovec_add(&qiov, start_buffer, start->nb_byte

Re: [Qemu-devel] [PATCH 7/7] qcow2: Merge the writing of the COW regions with the guest data

2017-05-26 Thread Kevin Wolf
Am 24.05.2017 um 21:05 hat Alberto Garcia geschrieben: > On Wed 24 May 2017 06:43:31 PM CEST, Anton Nefedov wrote: > >> +if (m->data_qiov) { > >> +qemu_iovec_reset(&qiov); > >> +qemu_iovec_add(&qiov, start_buffer, start->nb_bytes); > >> +qemu_iovec_concat(&qiov, m->data_

Re: [Qemu-devel] [PATCH 7/7] qcow2: Merge the writing of the COW regions with the guest data

2017-05-24 Thread Alberto Garcia
On Wed 24 May 2017 06:43:31 PM CEST, Anton Nefedov wrote: >> +if (m->data_qiov) { >> +qemu_iovec_reset(&qiov); >> +qemu_iovec_add(&qiov, start_buffer, start->nb_bytes); >> +qemu_iovec_concat(&qiov, m->data_qiov, 0, data_bytes); >> +qemu_iovec_add(&qiov, end_buffe

Re: [Qemu-devel] [PATCH 7/7] qcow2: Merge the writing of the COW regions with the guest data

2017-05-24 Thread Anton Nefedov
If the guest tries to write data that results on the allocation of a new cluster, instead of writing the guest data first and then the data from the COW regions, write everything together using one single I/O operation. This can improve the write performance by 25% or more, depending on several f

[Qemu-devel] [PATCH 7/7] qcow2: Merge the writing of the COW regions with the guest data

2017-05-23 Thread Alberto Garcia
If the guest tries to write data that results on the allocation of a new cluster, instead of writing the guest data first and then the data from the COW regions, write everything together using one single I/O operation. This can improve the write performance by 25% or more, depending on several fa