[Qemu-devel] [PATCH 7/8] qemu-iotests: fix test_stream_partial()

2015-04-16 Thread Alberto Garcia
This test is streaming to the top layer using the intermediate image as the base. This is a mistake since block-stream never copies data from the base image and its backing chain, so this is effectively a no-op. In addition to fixing the base parameter, this patch also writes some data to the inte

Re: [Qemu-devel] [PATCH 7/8] qemu-iotests: fix test_stream_partial()

2015-04-22 Thread Max Reitz
On 16.04.2015 17:12, Alberto Garcia wrote: This test is streaming to the top layer using the intermediate image as the base. This is a mistake since block-stream never copies data from the base image and its backing chain, so this is effectively a no-op. In addition to fixing the base parameter,

Re: [Qemu-devel] [PATCH 7/8] qemu-iotests: fix test_stream_partial()

2015-04-22 Thread Eric Blake
On 04/16/2015 09:12 AM, Alberto Garcia wrote: > This test is streaming to the top layer using the intermediate image > as the base. This is a mistake since block-stream never copies data > from the base image and its backing chain, so this is effectively a > no-op. > > In addition to fixing the ba

Re: [Qemu-devel] [PATCH 7/8] qemu-iotests: fix test_stream_partial()

2015-04-22 Thread Alberto Garcia
On Wed 22 Apr 2015 09:38:40 PM CEST, Eric Blake wrote: > You know, we should _also_ test a no-op stream, to prove that we > handle it correctly (we've had bugs in the past where 0-length active > commit behaved differently in the events it generated than non-zero > length), and your change is drop