Re: [Qemu-devel] [PATCH 7/9] target-arm: Simplify insn_crosses_page()

2017-10-10 Thread Richard Henderson
On 10/09/2017 06:48 AM, Peter Maydell wrote: > Recent changes have left insn_crosses_page() more complicated > than it needed to be: > * it's only called from thumb_tr_translate_insn() so we know >for certain that we're looking at a Thumb insn > * the caller's check for dc->pc >=

[Qemu-devel] [PATCH 7/9] target-arm: Simplify insn_crosses_page()

2017-10-09 Thread Peter Maydell
Recent changes have left insn_crosses_page() more complicated than it needed to be: * it's only called from thumb_tr_translate_insn() so we know for certain that we're looking at a Thumb insn * the caller's check for dc->pc >= dc->next_page_start - 3 means that dc->pc can't possibly be 4