Re: [Qemu-devel] [PATCH COLO-Frame v5 11/29] COLO VMstate: Load VM state into qsb before restore it

2015-06-08 Thread zhanghailiang
On 2015/6/6 2:02, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We should cache the device state before restore it, besides, we should call qemu_system_reset() before load VM state, which can ensure the data is intact. I think the description could be be

Re: [Qemu-devel] [PATCH COLO-Frame v5 11/29] COLO VMstate: Load VM state into qsb before restore it

2015-06-05 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > We should cache the device state before restore it, > besides, we should call qemu_system_reset() before load VM state, > which can ensure the data is intact. I think the description could be better; to me the important point is not that it

[Qemu-devel] [PATCH COLO-Frame v5 11/29] COLO VMstate: Load VM state into qsb before restore it

2015-05-21 Thread zhanghailiang
We should cache the device state before restore it, besides, we should call qemu_system_reset() before load VM state, which can ensure the data is intact. Note: If we discard qemu_system_reset(), there will be some odd error, For exmple, qemu in slave side crashes and reports: KVM: entry failed,