Re: [Qemu-devel] [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2013-01-15 Thread Matthew Ogilvie
On Fri, Jan 11, 2013 at 05:45:28PM +0200, Gleb Natapov wrote: > On Thu, Jan 10, 2013 at 11:40:07PM -0700, Matthew Ogilvie wrote: > > On Tue, Jan 08, 2013 at 09:31:19AM +0200, Gleb Natapov wrote: > > > On Mon, Jan 07, 2013 at 06:17:22PM -0600, mmogi...@miniinfo.net wrote: > > > > On Mon, 7 Jan 2013

Re: [Qemu-devel] [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2013-01-11 Thread Gleb Natapov
On Thu, Jan 10, 2013 at 11:40:07PM -0700, Matthew Ogilvie wrote: > On Tue, Jan 08, 2013 at 09:31:19AM +0200, Gleb Natapov wrote: > > On Mon, Jan 07, 2013 at 06:17:22PM -0600, mmogi...@miniinfo.net wrote: > > > On Mon, 7 Jan 2013 11:39:18 +0200, Gleb Natapov wrote: > > > > On Wed, Dec 26, 2012 at 1

Re: [Qemu-devel] [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2013-01-10 Thread Matthew Ogilvie
On Tue, Jan 08, 2013 at 09:31:19AM +0200, Gleb Natapov wrote: > On Mon, Jan 07, 2013 at 06:17:22PM -0600, mmogi...@miniinfo.net wrote: > > On Mon, 7 Jan 2013 11:39:18 +0200, Gleb Natapov wrote: > > > On Wed, Dec 26, 2012 at 10:39:53PM -0700, Matthew Ogilvie wrote: > > >> Reading the spec, it is cl

Re: [Qemu-devel] [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2013-01-07 Thread Gleb Natapov
On Mon, Jan 07, 2013 at 06:17:22PM -0600, mmogi...@miniinfo.net wrote: > On Mon, 7 Jan 2013 11:39:18 +0200, Gleb Natapov wrote: > > On Wed, Dec 26, 2012 at 10:39:53PM -0700, Matthew Ogilvie wrote: > >> Reading the spec, it is clear that most modes normally leave the IRQ > >> output line high, and

Re: [Qemu-devel] [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2013-01-07 Thread mmogilvi
On Mon, 7 Jan 2013 11:39:18 +0200, Gleb Natapov wrote: > On Wed, Dec 26, 2012 at 10:39:53PM -0700, Matthew Ogilvie wrote: >> Reading the spec, it is clear that most modes normally leave the IRQ >> output line high, and only pulse it low to generate a leading edge. >> Especially the most commonly u

Re: [Qemu-devel] [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2013-01-07 Thread Gleb Natapov
On Mon, Jan 07, 2013 at 11:39:18AM +0200, Gleb Natapov wrote: > On Wed, Dec 26, 2012 at 10:39:53PM -0700, Matthew Ogilvie wrote: > > Reading the spec, it is clear that most modes normally leave the IRQ > > output line high, and only pulse it low to generate a leading edge. > > Especially the most c

Re: [Qemu-devel] [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2013-01-07 Thread Gleb Natapov
On Wed, Dec 26, 2012 at 10:39:53PM -0700, Matthew Ogilvie wrote: > Reading the spec, it is clear that most modes normally leave the IRQ > output line high, and only pulse it low to generate a leading edge. > Especially the most commonly used mode 2. > > The KVM i8254 model does not try to emulate

[Qemu-devel] [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2012-12-26 Thread Matthew Ogilvie
Reading the spec, it is clear that most modes normally leave the IRQ output line high, and only pulse it low to generate a leading edge. Especially the most commonly used mode 2. The KVM i8254 model does not try to emulate the duration of the pulse at all, so just swap the high/low settings it to