Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-03-07 Thread Kevin Wolf
Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: > Properly account for the possibility of multiboot kernels with a zero > bss_end_addr. The Multiboot Specification, section 3.1.3 allows for > kernels without a bss section, by allowing a zeroed bss_end_addr multiboot > header field. > > Do s

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-03-06 Thread Jack Schwartz
Hi Kevin and everyone. On 2018-03-05 00:13, Kevin Wolf wrote: Am 02.03.2018 um 20:32 hat Jack Schwartz geschrieben: Hi Kevin. On 2018-01-15 07:54, Kevin Wolf wrote: Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: Properly account for the possibility of multiboot kernels with a zero bss

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-03-05 Thread Kevin Wolf
Am 02.03.2018 um 20:32 hat Jack Schwartz geschrieben: > Hi Kevin. > > On 2018-01-15 07:54, Kevin Wolf wrote: > > Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: > > > Properly account for the possibility of multiboot kernels with a zero > > > bss_end_addr. The Multiboot Specification, secti

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-03-02 Thread Jack Schwartz
Hi Kevin. On 2018-01-15 07:54, Kevin Wolf wrote: Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: Properly account for the possibility of multiboot kernels with a zero bss_end_addr. The Multiboot Specification, section 3.1.3 allows for kernels without a bss section, by allowing a zeroed b

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-01-22 Thread Daniel P. Berrange
On Fri, Jan 19, 2018 at 04:18:07PM -0800, Jack Schwartz wrote: > Hi Anatol, Daniel and Kevin. > > On 01/19/18 10:36, Anatol Pomozov wrote: > > Hello Jack > > > > On Wed, Jan 17, 2018 at 12:06 PM, Jack Schwartz > > wrote: > > > Hi Kevin and Anatol. > > > > > > Kevin, thanks for your review. > >

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-01-19 Thread Jack Schwartz
Hi Anatol, Daniel and Kevin. On 01/19/18 10:36, Anatol Pomozov wrote: Hello Jack On Wed, Jan 17, 2018 at 12:06 PM, Jack Schwartz wrote: Hi Kevin and Anatol. Kevin, thanks for your review. More inline below... On 01/15/18 07:54, Kevin Wolf wrote: Am 21.12.2017 um 18:25 hat Jack Schwartz ge

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-01-19 Thread Anatol Pomozov
Hello Jack On Wed, Jan 17, 2018 at 12:06 PM, Jack Schwartz wrote: > Hi Kevin and Anatol. > > Kevin, thanks for your review. > > More inline below... > > On 01/15/18 07:54, Kevin Wolf wrote: >> >> Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: >>> >>> Properly account for the possibility of

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-01-18 Thread Daniel P. Berrange
On Thu, Jan 18, 2018 at 12:35:00PM +0100, Kevin Wolf wrote: > Am 17.01.2018 um 21:06 hat Jack Schwartz geschrieben: > > Before I proceed with adding my multiboot test file, I'll clarify here that > > I started with a version from the grub2 tree.  In that file I expanded a > > header file, also from

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-01-18 Thread Kevin Wolf
Am 17.01.2018 um 21:06 hat Jack Schwartz geschrieben: > Before I proceed with adding my multiboot test file, I'll clarify here that > I started with a version from the grub2 tree.  In that file I expanded a > header file, also from the same tree.  Neither file had any license header, > though the t

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-01-17 Thread Jack Schwartz
Hi Kevin and Anatol. Kevin, thanks for your review. More inline below... On 01/15/18 07:54, Kevin Wolf wrote: Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: Properly account for the possibility of multiboot kernels with a zero bss_end_addr. The Multiboot Specification, section 3.1.3 a

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-01-15 Thread Kevin Wolf
Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: > Properly account for the possibility of multiboot kernels with a zero > bss_end_addr. The Multiboot Specification, section 3.1.3 allows for > kernels without a bss section, by allowing a zeroed bss_end_addr multiboot > header field. > > Do s

[Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2017-12-21 Thread Jack Schwartz
Properly account for the possibility of multiboot kernels with a zero bss_end_addr. The Multiboot Specification, section 3.1.3 allows for kernels without a bss section, by allowing a zeroed bss_end_addr multiboot header field. Do some cleanup to multiboot.c as well: - Remove some unused variables