Re: [Qemu-devel] [PATCH RESEND v15 08/10] target-arm: kvm64: inject synchronous External Abort

2018-11-26 Thread gengdongjiu
> >> > >> Hi Peter, > >> Thanks for the review and comments. > >> > >> > > >> > On 8 November 2018 at 10:29, Dongjiu Geng wrote: > >> > > +bool write_part_cpustate_to_list(ARMCPU *cpu, ptrdiff_t > >> > > +fieldoffset) > >> > > >> > What is this about? Nothing else in QEMU needs to mess with the

Re: [Qemu-devel] [PATCH RESEND v15 08/10] target-arm: kvm64: inject synchronous External Abort

2018-11-26 Thread Alex Bennée
Peter Maydell writes: > On Wed, 21 Nov 2018 at 14:34, gengdongjiu wrote: >> >> Hi Peter, >> Thanks for the review and comments. >> >> > >> > On 8 November 2018 at 10:29, Dongjiu Geng wrote: >> > > +bool write_part_cpustate_to_list(ARMCPU *cpu, ptrdiff_t fieldoffset) >> > >> > What is this a

Re: [Qemu-devel] [PATCH RESEND v15 08/10] target-arm: kvm64: inject synchronous External Abort

2018-11-23 Thread gengdongjiu
Hi Peter, On 2018/11/24 2:45, Peter Maydell wrote: > On Wed, 21 Nov 2018 at 14:34, gengdongjiu wrote: >> >> Hi Peter, >> Thanks for the review and comments. >> >>> >>> On 8 November 2018 at 10:29, Dongjiu Geng wrote: +bool write_part_cpustate_to_list(ARMCPU *cpu, ptrdiff_t fieldoffset) >>

Re: [Qemu-devel] [PATCH RESEND v15 08/10] target-arm: kvm64: inject synchronous External Abort

2018-11-23 Thread Peter Maydell
On Wed, 21 Nov 2018 at 14:34, gengdongjiu wrote: > > Hi Peter, > Thanks for the review and comments. > > > > > On 8 November 2018 at 10:29, Dongjiu Geng wrote: > > > +bool write_part_cpustate_to_list(ARMCPU *cpu, ptrdiff_t fieldoffset) > > > > What is this about? Nothing else in QEMU needs to m

Re: [Qemu-devel] [PATCH RESEND v15 08/10] target-arm: kvm64: inject synchronous External Abort

2018-11-21 Thread gengdongjiu
Hi Peter, Thanks for the review and comments. > > On 8 November 2018 at 10:29, Dongjiu Geng wrote: > > Add synchronous external abort injection logic, setup exception type > > and syndrome value. When switch to guest, guest will jump to the > > synchronous external abort vector table entry. >

Re: [Qemu-devel] [PATCH RESEND v15 08/10] target-arm: kvm64: inject synchronous External Abort

2018-11-20 Thread Peter Maydell
On 8 November 2018 at 10:29, Dongjiu Geng wrote: > Add synchronous external abort injection logic, setup > exception type and syndrome value. When switch to guest, > guest will jump to the synchronous external abort vector > table entry. > > The ESR_ELx.DFSC is set to synchronous external abort(0x

[Qemu-devel] [PATCH RESEND v15 08/10] target-arm: kvm64: inject synchronous External Abort

2018-11-08 Thread Dongjiu Geng
Add synchronous external abort injection logic, setup exception type and syndrome value. When switch to guest, guest will jump to the synchronous external abort vector table entry. The ESR_ELx.DFSC is set to synchronous external abort(0x10), and ESR_ELx.FnV is set to not valid(0x1), which will tel