Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

2017-06-08 Thread Stefan Hajnoczi
On Thu, Jun 08, 2017 at 10:41:49AM +0300, Manos Pitsidianakis wrote: > On Thu, Jun 08, 2017 at 08:22:28AM +0100, Stefan Hajnoczi wrote: > > On Wed, Jun 07, 2017 at 04:06:19PM +0300, Manos Pitsidianakis wrote: > > > +#define QEMU_OPT_IOPS_TOTAL "iops-total" > > > +#define QEMU_OPT_IOPS_TOTAL_MAX

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

2017-06-08 Thread Manos Pitsidianakis
On Thu, Jun 08, 2017 at 08:22:28AM +0100, Stefan Hajnoczi wrote: On Wed, Jun 07, 2017 at 04:06:19PM +0300, Manos Pitsidianakis wrote: +#define QEMU_OPT_IOPS_TOTAL "iops-total" +#define QEMU_OPT_IOPS_TOTAL_MAX "iops-total-max" +#define QEMU_OPT_IOPS_TOTAL_MAX_LENGTH "iops-total-max-length"

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

2017-06-08 Thread Stefan Hajnoczi
On Wed, Jun 07, 2017 at 04:06:19PM +0300, Manos Pitsidianakis wrote: > +#define QEMU_OPT_IOPS_TOTAL "iops-total" > +#define QEMU_OPT_IOPS_TOTAL_MAX "iops-total-max" > +#define QEMU_OPT_IOPS_TOTAL_MAX_LENGTH "iops-total-max-length" > +#define QEMU_OPT_IOPS_READ "iops-read" > +#define

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

2017-06-07 Thread Eric Blake
On 06/07/2017 05:08 PM, Manos Pitsidianakis wrote: > On Wed, Jun 07, 2017 at 04:38:43PM -0500, Eric Blake wrote: >> On 06/07/2017 11:06 AM, Manos Pitsidianakis wrote: >>> On Wed, Jun 07, 2017 at 10:40:08AM -0500, Eric Blake wrote: On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote: > This

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

2017-06-07 Thread Manos Pitsidianakis
On Wed, Jun 07, 2017 at 04:38:43PM -0500, Eric Blake wrote: On 06/07/2017 11:06 AM, Manos Pitsidianakis wrote: On Wed, Jun 07, 2017 at 10:40:08AM -0500, Eric Blake wrote: On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote: This is part of my work for my GSOC project this summer. I am not sure

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

2017-06-07 Thread Eric Blake
On 06/07/2017 11:06 AM, Manos Pitsidianakis wrote: > On Wed, Jun 07, 2017 at 10:40:08AM -0500, Eric Blake wrote: >> On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote: >>> This is part of my work for my GSOC project this summer. >>> >>> I am not sure if the count parameter in bdrv_co_pwrite_zeros

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

2017-06-07 Thread Manos Pitsidianakis
On Wed, Jun 07, 2017 at 10:40:08AM -0500, Eric Blake wrote: On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote: This is part of my work for my GSOC project this summer. I am not sure if the count parameter in bdrv_co_pwrite_zeros and bdrv_co_pdiscard refers to sectors or bytes. Both refer to

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

2017-06-07 Thread Eric Blake
On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote: > This is part of my work for my GSOC project this summer. > > I am not sure if the count parameter in bdrv_co_pwrite_zeros and > bdrv_co_pdiscard refers to sectors or bytes. Both refer to byte counts. (We're trying to get rid of as many

[Qemu-devel] [PATCH RFC] block: add throttle block filter driver

2017-06-07 Thread Manos Pitsidianakis
This is part of my work for my GSOC project this summer. I am not sure if the count parameter in bdrv_co_pwrite_zeros and bdrv_co_pdiscard refers to sectors or bytes. Should this be handled differently? The driver can only be instantiated in the command line for now like in the following