Re: [Qemu-devel] [PATCH RFC] file-posix: make lock_fd read-only

2017-10-18 Thread Fam Zheng
On Wed, 10/11 11:48, Kevin Wolf wrote: > Am 11.10.2017 um 11:38 hat Vladimir Sementsov-Ogievskiy geschrieben: > > 11.10.2017 12:22, Kevin Wolf wrote: > > > [ Cc: Fam ] Sorry for being slow, now finally getting my hands on email backlog after holiday and preparing for KVM Forum presentation. > > >

Re: [Qemu-devel] [PATCH RFC] file-posix: make lock_fd read-only

2017-10-11 Thread Kevin Wolf
Am 11.10.2017 um 11:38 hat Vladimir Sementsov-Ogievskiy geschrieben: > 11.10.2017 12:22, Kevin Wolf wrote: > > [ Cc: Fam ] > > > > Am 10.10.2017 um 15:42 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > We do not reopen lock_fd on bdrv_reopen which leads to problems on > > > reopen image RO. So

Re: [Qemu-devel] [PATCH RFC] file-posix: make lock_fd read-only

2017-10-11 Thread Vladimir Sementsov-Ogievskiy
11.10.2017 12:22, Kevin Wolf wrote: [ Cc: Fam ] Am 10.10.2017 um 15:42 hat Vladimir Sementsov-Ogievskiy geschrieben: We do not reopen lock_fd on bdrv_reopen which leads to problems on reopen image RO. So, lets make lock_fd be always RO. This is correct, because qemu_lock_fd always called with e

Re: [Qemu-devel] [PATCH RFC] file-posix: make lock_fd read-only

2017-10-11 Thread Kevin Wolf
[ Cc: Fam ] Am 10.10.2017 um 15:42 hat Vladimir Sementsov-Ogievskiy geschrieben: > We do not reopen lock_fd on bdrv_reopen which leads to problems on > reopen image RO. So, lets make lock_fd be always RO. > This is correct, because qemu_lock_fd always called with exclusive=false > on lock_fd. > >

Re: [Qemu-devel] [PATCH RFC] file-posix: make lock_fd read-only

2017-10-10 Thread Eric Blake
On 10/10/2017 02:30 PM, Denis V. Lunev wrote: > On 10/10/2017 09:50 PM, Eric Blake wrote: >> On 10/10/2017 08:42 AM, Vladimir Sementsov-Ogievskiy wrote: >>> We do not reopen lock_fd on bdrv_reopen which leads to problems on >>> reopen image RO. So, lets make lock_fd be always RO. >>> This is correc

Re: [Qemu-devel] [PATCH RFC] file-posix: make lock_fd read-only

2017-10-10 Thread Denis V. Lunev
On 10/10/2017 09:50 PM, Eric Blake wrote: > On 10/10/2017 08:42 AM, Vladimir Sementsov-Ogievskiy wrote: >> We do not reopen lock_fd on bdrv_reopen which leads to problems on >> reopen image RO. So, lets make lock_fd be always RO. >> This is correct, because qemu_lock_fd always called with exclusive

Re: [Qemu-devel] [PATCH RFC] file-posix: make lock_fd read-only

2017-10-10 Thread Eric Blake
On 10/10/2017 08:42 AM, Vladimir Sementsov-Ogievskiy wrote: > We do not reopen lock_fd on bdrv_reopen which leads to problems on > reopen image RO. So, lets make lock_fd be always RO. > This is correct, because qemu_lock_fd always called with exclusive=false > on lock_fd. How is that correct? fil

[Qemu-devel] [PATCH RFC] file-posix: make lock_fd read-only

2017-10-10 Thread Vladimir Sementsov-Ogievskiy
We do not reopen lock_fd on bdrv_reopen which leads to problems on reopen image RO. So, lets make lock_fd be always RO. This is correct, because qemu_lock_fd always called with exclusive=false on lock_fd. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! We've faced the following problem