[Qemu-devel] [PATCH RFC] kvm: ignore apic polarity

2014-02-27 Thread Michael S. Tsirkin
apic polarity in KVM does not work: too many things assume active high. Let's not pretend it works, let's just ignore polarity flag. If we ever want to emulate it exactly, this will need a feature flag anyway. Also report this to userspace: this makes it possible to report the interrupt active-lo

Re: [Qemu-devel] [PATCH RFC] kvm: ignore apic polarity

2014-02-27 Thread Gabriel L. Somlo
On Thu, Feb 27, 2014 at 07:05:49PM +0200, Michael S. Tsirkin wrote: > apic polarity in KVM does not work: too many things assume active high. > Let's not pretend it works, let's just ignore polarity flag. If we ever > want to emulate it exactly, this will need a feature flag anyway. > > Also repo

Re: [Qemu-devel] [PATCH RFC] kvm: ignore apic polarity

2014-02-27 Thread Paolo Bonzini
Il 27/02/2014 22:41, Gabriel L. Somlo ha scritto: On Thu, Feb 27, 2014 at 07:05:49PM +0200, Michael S. Tsirkin wrote: apic polarity in KVM does not work: too many things assume active high. Let's not pretend it works, let's just ignore polarity flag. If we ever want to emulate it exactly, this

Re: [Qemu-devel] [PATCH RFC] kvm: ignore apic polarity

2014-02-27 Thread Gabriel L. Somlo
On Thu, Feb 27, 2014 at 11:30:55PM +0100, Paolo Bonzini wrote: > Il 27/02/2014 22:41, Gabriel L. Somlo ha scritto: > >On Thu, Feb 27, 2014 at 07:05:49PM +0200, Michael S. Tsirkin wrote: > >>apic polarity in KVM does not work: too many things assume active high. > >>Let's not pretend it works, let's

Re: [Qemu-devel] [PATCH RFC] kvm: ignore apic polarity

2014-02-27 Thread Paolo Bonzini
Il 28/02/2014 00:13, Gabriel L. Somlo ha scritto: On Thu, Feb 27, 2014 at 11:30:55PM +0100, Paolo Bonzini wrote: Il 27/02/2014 22:41, Gabriel L. Somlo ha scritto: On Thu, Feb 27, 2014 at 07:05:49PM +0200, Michael S. Tsirkin wrote: apic polarity in KVM does not work: too many things assume acti

Re: [Qemu-devel] [PATCH RFC] kvm: ignore apic polarity

2014-02-27 Thread Michael S. Tsirkin
On Thu, Feb 27, 2014 at 11:30:55PM +0100, Paolo Bonzini wrote: > Il 27/02/2014 22:41, Gabriel L. Somlo ha scritto: > >On Thu, Feb 27, 2014 at 07:05:49PM +0200, Michael S. Tsirkin wrote: > >>apic polarity in KVM does not work: too many things assume active high. > >>Let's not pretend it works, let's

Re: [Qemu-devel] [PATCH RFC] kvm: ignore apic polarity

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 05:55, Michael S. Tsirkin ha scritto: Why? We already have different ACPI tables for TCG vs KVM. Specifically apic interrupt override flag in MADT is set for KVM but not TCG. It used to be this way, but bool kvm_allows_irq0_override(void) { return !kvm_irqchip_in_kerne

Re: [Qemu-devel] [PATCH RFC] kvm: ignore apic polarity

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 05:55, Michael S. Tsirkin ha scritto: Why? We already have different ACPI tables for TCG vs KVM. Specifically apic interrupt override flag in MADT is set for KVM but not TCG. It used to be this way, but bool kvm_allows_irq0_override(void) { return !kvm_irqchip_in_kerne

Re: [Qemu-devel] [PATCH RFC] kvm: ignore apic polarity

2014-02-28 Thread Alex Williamson
On Thu, 2014-02-27 at 19:05 +0200, Michael S. Tsirkin wrote: > apic polarity in KVM does not work: too many things assume active high. > Let's not pretend it works, let's just ignore polarity flag. If we ever > want to emulate it exactly, this will need a feature flag anyway. > > Also report this