Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-06-18 Thread Michael S. Tsirkin
On Tue, Mar 20, 2012 at 10:22:42AM +1030, Rusty Russell wrote: On Mon, 19 Mar 2012 17:13:06 -0500, Anthony Liguori anth...@codemonkey.ws wrote: Maybe just make this a hidden option like x-miio? x-violate-the-virtio-spec-to-trick-old-linux-drivers-into-working-on-power? To configure

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-20 Thread Avi Kivity
On 03/19/2012 08:57 PM, Michael S. Tsirkin wrote: Should be done via an extra BAR (with the same layout, perhaps extended) so compatibility is preserved. No, that would need guest changes to be of use. The point of this hack is to make things work for Linux guests where PIO does not

[Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-19 Thread Michael S. Tsirkin
Currently virtio-pci is specified so that configuration of the device is done through a PCI IO space (via BAR 0 of the virtual PCI device). However, Linux guests happen to use ioread/iowrite/iomap primitives for access, and these work uniformly across memory/io BARs. While PCI IO accesses are

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-19 Thread Avi Kivity
On 03/19/2012 05:56 PM, Michael S. Tsirkin wrote: Currently virtio-pci is specified so that configuration of the device is done through a PCI IO space (via BAR 0 of the virtual PCI device). However, Linux guests happen to use ioread/iowrite/iomap primitives for access, and these work uniformly

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-19 Thread Michael S. Tsirkin
On Mon, Mar 19, 2012 at 07:58:12PM +0200, Avi Kivity wrote: On 03/19/2012 05:56 PM, Michael S. Tsirkin wrote: Currently virtio-pci is specified so that configuration of the device is done through a PCI IO space (via BAR 0 of the virtual PCI device). However, Linux guests happen to use

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-19 Thread Anthony Liguori
On 03/19/2012 10:56 AM, Michael S. Tsirkin wrote: Currently virtio-pci is specified so that configuration of the device is done through a PCI IO space (via BAR 0 of the virtual PCI device). However, Linux guests happen to use ioread/iowrite/iomap primitives for access, and these work uniformly

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-19 Thread Michael S. Tsirkin
On Mon, Mar 19, 2012 at 02:19:33PM -0500, Anthony Liguori wrote: On 03/19/2012 10:56 AM, Michael S. Tsirkin wrote: Currently virtio-pci is specified so that configuration of the device is done through a PCI IO space (via BAR 0 of the virtual PCI device). However, Linux guests happen to use

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-19 Thread Anthony Liguori
On 03/19/2012 03:49 PM, Michael S. Tsirkin wrote: On Mon, Mar 19, 2012 at 02:19:33PM -0500, Anthony Liguori wrote: On 03/19/2012 10:56 AM, Michael S. Tsirkin wrote: Currently virtio-pci is specified so that configuration of the device is done through a PCI IO space (via BAR 0 of the virtual

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-19 Thread Michael S. Tsirkin
On Mon, Mar 19, 2012 at 04:07:45PM -0500, Anthony Liguori wrote: On 03/19/2012 03:49 PM, Michael S. Tsirkin wrote: On Mon, Mar 19, 2012 at 02:19:33PM -0500, Anthony Liguori wrote: On 03/19/2012 10:56 AM, Michael S. Tsirkin wrote: Currently virtio-pci is specified so that configuration of the

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-19 Thread Michael S. Tsirkin
On Mon, Mar 19, 2012 at 04:07:45PM -0500, Anthony Liguori wrote: On 03/19/2012 03:49 PM, Michael S. Tsirkin wrote: On Mon, Mar 19, 2012 at 02:19:33PM -0500, Anthony Liguori wrote: On 03/19/2012 10:56 AM, Michael S. Tsirkin wrote: Currently virtio-pci is specified so that configuration of the

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-19 Thread Anthony Liguori
On 03/19/2012 04:29 PM, Michael S. Tsirkin wrote: On Mon, Mar 19, 2012 at 04:07:45PM -0500, Anthony Liguori wrote: On 03/19/2012 03:49 PM, Michael S. Tsirkin wrote: On Mon, Mar 19, 2012 at 02:19:33PM -0500, Anthony Liguori wrote: On 03/19/2012 10:56 AM, Michael S. Tsirkin wrote: Currently

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-19 Thread Rusty Russell
On Mon, 19 Mar 2012 17:13:06 -0500, Anthony Liguori anth...@codemonkey.ws wrote: Maybe just make this a hidden option like x-miio? x-violate-the-virtio-spec-to-trick-old-linux-drivers-into-working-on-power? To configure the device, we use the first I/O region of the PCI device. Meh, it

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-19 Thread Anthony Liguori
On 03/19/2012 06:52 PM, Rusty Russell wrote: On Mon, 19 Mar 2012 17:13:06 -0500, Anthony Liguorianth...@codemonkey.ws wrote: Maybe just make this a hidden option like x-miio? x-violate-the-virtio-spec-to-trick-old-linux-drivers-into-working-on-power? To configure the device, we use the