Re: [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking

2015-08-14 Thread Paul Eggert
Peter Maydell wrote: I just don't want a GPLv3-licensed file in the git repo and an integrated part of our build-and-test system... My kneejerk reaction is that the build procedures in question are large enough that they should stay GPLv3. If you don't want those files in your git repo you c

Re: [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking

2015-08-14 Thread Peter Maydell
On 14 August 2015 at 11:30, Paul Eggert wrote: > Peter Maydell wrote: >> I just don't want >> a GPLv3-licensed file in the git repo and an integrated part >> of our build-and-test system... > > > My kneejerk reaction is that the build procedures in question are large > enough that they should stay

Re: [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking

2015-08-14 Thread Daniel P. Berrange
On Thu, Aug 13, 2015 at 09:39:48PM +0100, Peter Maydell wrote: > On 13 August 2015 at 19:27, Eric Blake wrote: > > It's worth asking the gnulib folks for an opinion on whether relaxing > > the license on maint.mk and GNUmakefile to explicitly go back to GPLv2+, > > and/or explicitly add some expli

Re: [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking

2015-08-13 Thread Peter Maydell
On 13 August 2015 at 19:27, Eric Blake wrote: > It's worth asking the gnulib folks for an opinion on whether relaxing > the license on maint.mk and GNUmakefile to explicitly go back to GPLv2+, > and/or explicitly add some explicit exception clause like gcc that makes > it clear that using these fi

Re: [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking

2015-08-13 Thread Eric Blake
[adding the gnulib list] On 08/13/2015 11:53 AM, Peter Maydell wrote: > On 31 July 2015 at 17:30, Daniel P. Berrange wrote: >> Historically QEMU has relied on the checkpatch.pl script, >> borrowed from Linux, to check coding style compliance on >> patches which are submitted. For what it is desig

Re: [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking

2015-08-13 Thread Peter Maydell
On 31 July 2015 at 17:30, Daniel P. Berrange wrote: > Historically QEMU has relied on the checkpatch.pl script, > borrowed from Linux, to check coding style compliance on > patches which are submitted. For what it is designed for, > it does a reasonable job, but I feel that QEMU would benefit > fr

[Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking

2015-07-31 Thread Daniel P. Berrange
Historically QEMU has relied on the checkpatch.pl script, borrowed from Linux, to check coding style compliance on patches which are submitted. For what it is designed for, it does a reasonable job, but I feel that QEMU would benefit from some more checking in this area, in particular checks that r