Re: [Qemu-devel] [PATCH RFC 01/11] TCG translation

2019-01-23 Thread Yoshinori Sato
On Wed, 23 Jan 2019 12:17:46 +0900, Richard Henderson wrote: > > On 1/21/19 5:15 AM, Yoshinori Sato wrote: > > +/* PSW condition operation */ > > +typedef struct { > > +TCGv op_mode; > > +TCGv op_a1[13]; > > +TCGv op_a2[13]; > > +TCGv op_r[13]; > > +} CCOP; > > +CCOP ccop; > > Why

Re: [Qemu-devel] [PATCH RFC 01/11] TCG translation

2019-01-22 Thread Richard Henderson
On 1/21/19 5:15 AM, Yoshinori Sato wrote: > +/* PSW condition operation */ > +typedef struct { > +TCGv op_mode; > +TCGv op_a1[13]; > +TCGv op_a2[13]; > +TCGv op_r[13]; > +} CCOP; > +CCOP ccop; Why does this have different array sizes than cpu.h? Indeed, why does this have array si

Re: [Qemu-devel] [PATCH RFC 01/11] TCG translation

2019-01-22 Thread Yoshinori Sato
On Mon, 21 Jan 2019 22:35:43 +0900, Thomas Huth wrote: > > On 2019-01-21 14:15, Yoshinori Sato wrote: > > This part only supported RXv1 instructions. > > Instruction manual. > > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf > > > > Signed-off-by: Yoshino

Re: [Qemu-devel] [PATCH RFC 01/11] TCG translation

2019-01-21 Thread Thomas Huth
On 2019-01-21 14:15, Yoshinori Sato wrote: > This part only supported RXv1 instructions. > Instruction manual. > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf > > Signed-off-by: Yoshinori Sato > --- [...] > diff --git a/target/rx/op_helper.c b/target/rx/

[Qemu-devel] [PATCH RFC 01/11] TCG translation

2019-01-21 Thread Yoshinori Sato
This part only supported RXv1 instructions. Instruction manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf Signed-off-by: Yoshinori Sato --- target/rx/helper.h| 22 + target/rx/op_helper.c | 548 + target/rx/translate.c | 3003