Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread Halil Pasic
On 09/15/2017 03:37 PM, David Hildenbrand wrote: > On 15.09.2017 15:22, Cornelia Huck wrote: >> On Fri, 15 Sep 2017 15:09:02 +0200 >> David Hildenbrand wrote: >> >>> On 15.09.2017 15:07, Cornelia Huck wrote: On Fri, 15 Sep 2017 13:57:40 +0200 David Hildenbrand wrote: > As

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread David Hildenbrand
On 15.09.2017 15:22, Cornelia Huck wrote: > On Fri, 15 Sep 2017 15:09:02 +0200 > David Hildenbrand wrote: > >> On 15.09.2017 15:07, Cornelia Huck wrote: >>> On Fri, 15 Sep 2017 13:57:40 +0200 >>> David Hildenbrand wrote: >>> As an alternative, simply diff --git a/target/s390x/c

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread Cornelia Huck
On Fri, 15 Sep 2017 15:09:02 +0200 David Hildenbrand wrote: > On 15.09.2017 15:07, Cornelia Huck wrote: > > On Fri, 15 Sep 2017 13:57:40 +0200 > > David Hildenbrand wrote: > > > >> As an alternative, simply > >> > >> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > >> inde

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread David Hildenbrand
On 15.09.2017 15:07, Cornelia Huck wrote: > On Fri, 15 Sep 2017 13:57:40 +0200 > David Hildenbrand wrote: > >> As an alternative, simply >> >> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c >> index 0f28ebd162..0f22efc3b6 100644 >> --- a/target/s390x/cpu_models.c >> +++ b/targ

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread Cornelia Huck
On Fri, 15 Sep 2017 13:57:40 +0200 David Hildenbrand wrote: > As an alternative, simply > > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > index 0f28ebd162..0f22efc3b6 100644 > --- a/target/s390x/cpu_models.c > +++ b/target/s390x/cpu_models.c > @@ -195,6 +195,8 @@ bool s390

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread David Hildenbrand
On 15.09.2017 12:14, Cornelia Huck wrote: > d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made > registering the s390 pci host bridge conditional on presense > of the zpci facility bit. Sadly, that breaks migration from > some old machines. > > Create the s390 phb if we need it for compa

[Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread Cornelia Huck
d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made registering the s390 pci host bridge conditional on presense of the zpci facility bit. Sadly, that breaks migration from some old machines. Create the s390 phb if we need it for compat reasons, even if we don't provide the zpci facility.