Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2014-01-09 Thread Amos Kong
On Wed, Jan 08, 2014 at 09:53:02PM +0530, Amit Shah wrote: > On (Wed) 08 Jan 2014 [17:14:41], Amos Kong wrote: > > On Wed, Dec 18, 2013 at 11:05:14AM +0100, Giuseppe Scrivano wrote: > > > Markus Armbruster writes: > > > > > > > Amos Kong writes: > > > > > > > >> Bugzilla: https://bugs.launchpad.

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2014-01-08 Thread Amit Shah
On (Wed) 08 Jan 2014 [17:14:41], Amos Kong wrote: > On Wed, Dec 18, 2013 at 11:05:14AM +0100, Giuseppe Scrivano wrote: > > Markus Armbruster writes: > > > > > Amos Kong writes: > > > > > >> Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563 > > >> > > >> We have a requests queue to cache the

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2014-01-08 Thread Amos Kong
On Wed, Dec 18, 2013 at 11:05:14AM +0100, Giuseppe Scrivano wrote: > Markus Armbruster writes: > > > Amos Kong writes: > > > >> Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563 > >> > >> We have a requests queue to cache the random data, but the second > >> will come in when the first requ

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2013-12-24 Thread Varad Gautam
On Tue, Dec 17, 2013 at 12:33 PM, Amos Kong wrote: > > In my test host, When I use the egd-socket, it is very slow. > So I use a quick souce /dev/urandom, we ignore the egd protocol > here, it might be wrong. > > > Can you suggest a way to test this the right way? > > It seems we should still use

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2013-12-18 Thread Giuseppe Scrivano
Markus Armbruster writes: > Amos Kong writes: > >> Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563 >> >> We have a requests queue to cache the random data, but the second >> will come in when the first request is returned, so we always >> only have one items in the queue. It effects the p

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2013-12-17 Thread Amit Shah
On (Tue) 17 Dec 2013 [08:47:34], Markus Armbruster wrote: > Amos Kong writes: > > > Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563 > > > > We have a requests queue to cache the random data, but the second > > will come in when the first request is returned, so we always > > only have one

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2013-12-16 Thread Markus Armbruster
Amos Kong writes: > Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563 > > We have a requests queue to cache the random data, but the second > will come in when the first request is returned, so we always > only have one items in the queue. It effects the performance. > > This patch changes t

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2013-12-16 Thread Amos Kong
On Tue, Dec 17, 2013 at 11:22:14AM +0530, Amit Shah wrote: > On (Mon) 16 Dec 2013 [15:19:31], Anthony Liguori wrote: > > On Mon, Dec 16, 2013 at 8:36 AM, Amit Shah wrote: > > > On (Mon) 09 Dec 2013 [22:10:12], Amos Kong wrote: > > >> Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563 > > >> >

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2013-12-16 Thread Amit Shah
On (Mon) 16 Dec 2013 [15:19:31], Anthony Liguori wrote: > On Mon, Dec 16, 2013 at 8:36 AM, Amit Shah wrote: > > On (Mon) 09 Dec 2013 [22:10:12], Amos Kong wrote: > >> Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563 > >> > >> We have a requests queue to cache the random data, but the second

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2013-12-16 Thread Anthony Liguori
On Mon, Dec 16, 2013 at 8:36 AM, Amit Shah wrote: > On (Mon) 09 Dec 2013 [22:10:12], Amos Kong wrote: >> Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563 >> >> We have a requests queue to cache the random data, but the second >> will come in when the first request is returned, so we always >

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2013-12-16 Thread Amit Shah
On (Mon) 09 Dec 2013 [22:10:12], Amos Kong wrote: > Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563 > > We have a requests queue to cache the random data, but the second > will come in when the first request is returned, so we always > only have one items in the queue. It effects the perfor

[Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2013-12-09 Thread Amos Kong
Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563 We have a requests queue to cache the random data, but the second will come in when the first request is returned, so we always only have one items in the queue. It effects the performance. This patch changes the IOthread to fill a fixed buff