Re: [Qemu-devel] [PATCH RFC 1/3] error: don't rely on pointer comparisons

2015-06-17 Thread Kevin Wolf
Am 17.06.2015 um 08:57 hat Michael S. Tsirkin geschrieben: > On Tue, Jun 16, 2015 at 09:03:44AM -0600, Eric Blake wrote: > > On 06/16/2015 06:53 AM, Michael S. Tsirkin wrote: > > > makes it possible to copy error_abort pointers, > > > not just pass them on directly. > > > > > > Signed-off-by: Mich

Re: [Qemu-devel] [PATCH RFC 1/3] error: don't rely on pointer comparisons

2015-06-16 Thread Michael S. Tsirkin
On Tue, Jun 16, 2015 at 09:03:44AM -0600, Eric Blake wrote: > On 06/16/2015 06:53 AM, Michael S. Tsirkin wrote: > > makes it possible to copy error_abort pointers, > > not just pass them on directly. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > util/error.c | 16 +++- > > 1

Re: [Qemu-devel] [PATCH RFC 1/3] error: don't rely on pointer comparisons

2015-06-16 Thread Eric Blake
On 06/16/2015 06:53 AM, Michael S. Tsirkin wrote: > makes it possible to copy error_abort pointers, > not just pass them on directly. > > Signed-off-by: Michael S. Tsirkin > --- > util/error.c | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/util/error.

Re: [Qemu-devel] [PATCH RFC 1/3] error: don't rely on pointer comparisons

2015-06-16 Thread Eric Blake
On 06/16/2015 06:53 AM, Michael S. Tsirkin wrote: > makes it possible to copy error_abort pointers, > not just pass them on directly. > > Signed-off-by: Michael S. Tsirkin > --- > util/error.c | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) Where is this patch needed?

Re: [Qemu-devel] [PATCH RFC 1/3] error: don't rely on pointer comparisons

2015-06-16 Thread Eric Blake
On 06/16/2015 08:45 AM, Eric Blake wrote: > On 06/16/2015 06:53 AM, Michael S. Tsirkin wrote: >> makes it possible to copy error_abort pointers, >> not just pass them on directly. >> >> Signed-off-by: Michael S. Tsirkin >> --- >> util/error.c | 16 +++- >> 1 file changed, 11 insertion

Re: [Qemu-devel] [PATCH RFC 1/3] error: don't rely on pointer comparisons

2015-06-16 Thread Michael S. Tsirkin
On Tue, Jun 16, 2015 at 08:45:05AM -0600, Eric Blake wrote: > On 06/16/2015 06:53 AM, Michael S. Tsirkin wrote: > > makes it possible to copy error_abort pointers, > > not just pass them on directly. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > util/error.c | 16 +++- > > 1

[Qemu-devel] [PATCH RFC 1/3] error: don't rely on pointer comparisons

2015-06-16 Thread Michael S. Tsirkin
makes it possible to copy error_abort pointers, not just pass them on directly. Signed-off-by: Michael S. Tsirkin --- util/error.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/util/error.c b/util/error.c index 14f4351..ccf29ea 100644 --- a/util/error.c ++