Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-05-04 Thread Markus Armbruster
Eric Blake writes: > On 04/02/2015 11:29 AM, Markus Armbruster wrote: > >> >> * Implicit type definitions are made explicit, and given >> auto-generated names. These names start with ':' so they don't >> clash with the user's names. >> >> Example: a simple union implicitly defines an enu

Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-05-01 Thread Eric Blake
On 04/02/2015 11:29 AM, Markus Armbruster wrote: > > * Implicit type definitions are made explicit, and given > auto-generated names. These names start with ':' so they don't > clash with the user's names. > > Example: a simple union implicitly defines an enumeration type for > its disc

Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-04-29 Thread Markus Armbruster
Kevin Wolf writes: > One question in addition to what Eric already asked: > > Am 02.04.2015 um 19:29 hat Markus Armbruster geschrieben: >> +{ 'enum': 'SchemaMetaType', >> + 'data': [ 'builtin', 'enum', 'array', 'object', 'alternate', >> +'command', 'event' ] } >> + >> +{ 'type': 'Sch

Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-04-29 Thread Markus Armbruster
Eric Blake writes: > On 04/02/2015 11:29 AM, Markus Armbruster wrote: >> Caution, rough edges. >> >> qapi/introspect.json defines the introspection schema. It should do >> for uses other than QMP. > > That is, QGA should also be able to reuse it for introspection. > >> FIXME it's almost entirel

Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-04-23 Thread Eric Blake
On 04/23/2015 06:55 AM, Kevin Wolf wrote: > Am 15.04.2015 um 14:56 hat Eric Blake geschrieben: >> On 04/15/2015 03:16 AM, Alberto Garcia wrote: >>> On Sat 11 Apr 2015 01:06:58 AM CEST, Eric Blake wrote: >>> > +{ 'type': 'SchemaInfoEnum', > + 'data': { 'values': ['str'] } } At on

Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-04-23 Thread Kevin Wolf
One question in addition to what Eric already asked: Am 02.04.2015 um 19:29 hat Markus Armbruster geschrieben: > +{ 'enum': 'SchemaMetaType', > + 'data': [ 'builtin', 'enum', 'array', 'object', 'alternate', > +'command', 'event' ] } > + > +{ 'type': 'SchemaInfoBase', > + 'data': { 'n

Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-04-23 Thread Kevin Wolf
Am 15.04.2015 um 14:56 hat Eric Blake geschrieben: > On 04/15/2015 03:16 AM, Alberto Garcia wrote: > > On Sat 11 Apr 2015 01:06:58 AM CEST, Eric Blake wrote: > > > >>> +{ 'type': 'SchemaInfoEnum', > >>> + 'data': { 'values': ['str'] } } > >> > >> At one point, one thread suggested that we might

Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-04-15 Thread Eric Blake
On 04/15/2015 03:16 AM, Alberto Garcia wrote: > On Sat 11 Apr 2015 01:06:58 AM CEST, Eric Blake wrote: > >>> +{ 'type': 'SchemaInfoEnum', >>> + 'data': { 'values': ['str'] } } >> >> At one point, one thread suggested that we might want to allow QAPI to >> support enums with fixed values, as in:

Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-04-15 Thread Alberto Garcia
On Sat 11 Apr 2015 01:06:58 AM CEST, Eric Blake wrote: >> +{ 'type': 'SchemaInfoEnum', >> + 'data': { 'values': ['str'] } } > > At one point, one thread suggested that we might want to allow QAPI to > support enums with fixed values, as in: > > 'data': [ {'one': 1}, {'three': 3} ] Out of curios

Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-04-10 Thread Eric Blake
On 04/02/2015 11:29 AM, Markus Armbruster wrote: > Caution, rough edges. > > qapi/introspect.json defines the introspection schema. It should do > for uses other than QMP. That is, QGA should also be able to reuse it for introspection. > FIXME it's almost entirely devoid of comments. Yeah, but

[Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-04-02 Thread Markus Armbruster
Caution, rough edges. qapi/introspect.json defines the introspection schema. It should do for uses other than QMP. FIXME it's almost entirely devoid of comments. The introspection schema does not reflect all the rules and restrictions that apply to QAPI schemata. A valid QAPI schema has an intr