Re: [Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500

2015-10-21 Thread Shlomo Pongratz
On Wednesday, October 21, 2015, Peter Maydell wrote: > On 21 October 2015 at 12:33, Shlomo Pongratz > wrote: > > I assume I can add the system registers to target-arm/cpu.c but I wonder > if > > someone really needs to simulate

Re: [Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500

2015-10-21 Thread Shlomo Pongratz
O.K. On Wednesday, October 21, 2015, Pavel Fedin wrote: > Hello! > > >> The system register implementation belongs in the gic code, not > >> target-arm/. We already have support for devices that say > >> "I have some system registers, please add them to this CPU". > > > I

Re: [Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500

2015-10-21 Thread Peter Maydell
On 21 October 2015 at 14:01, Shlomo Pongratz wrote: > On Wednesday, October 21, 2015, Peter Maydell > wrote: >> The system register implementation belongs in the gic code, not >> target-arm/. We already have support for devices that say >> "I

Re: [Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500

2015-10-21 Thread Pavel Fedin
Hello! >> The system register implementation belongs in the gic code, not >> target-arm/. We already have support for devices that say >> "I have some system registers, please add them to this CPU". > I don't understand. > The system registers are defined in ARM Architecture reference Manual. >

Re: [Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500

2015-10-21 Thread Pavel Fedin
Hello! > I see, just how do I pass the gic version from the command line? Easy. -machine virt,gic-version=3 > GICV3 is accessed by system instructions that exists only in ARCH64. Wrong. In 32-bit mode the CPU sees them as CP15 registers. See "8.5 AArch32 System register descriptions". I

Re: [Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500

2015-10-21 Thread Pavel Fedin
Hello! > -Original Message- > From: Shlomo Pongratz [mailto:shlomopongr...@gmail.com] > Sent: Tuesday, October 20, 2015 8:22 PM > To: qemu-devel@nongnu.org > Cc: p.fe...@samsung.com; peter.mayd...@linaro.org; eric.au...@linaro.org; > shannon.z...@linaro.org; imamm...@redhat.com;

Re: [Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500

2015-10-21 Thread Shlomo Pongratz
See inline On Wednesday, October 21, 2015, Pavel Fedin wrote: > Hello! > > > I see, just how do I pass the gic version from the command line? > > Easy. -machine virt,gic-version=3 > > > GICV3 is accessed by system instructions that exists only in ARCH64. > > Wrong. In

Re: [Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500

2015-10-21 Thread Peter Maydell
On 21 October 2015 at 12:33, Shlomo Pongratz wrote: > I assume I can add the system registers to target-arm/cpu.c but I wonder if > someone really needs to simulate more than 8 AArch32 CPU(s) The system register implementation belongs in the gic code, not target-arm/.

Re: [Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500

2015-10-21 Thread Shlomo Pongratz
See inline. On Wednesday, October 21, 2015, Pavel Fedin wrote: > Hello! > > > -Original Message- > > From: Shlomo Pongratz [mailto:shlomopongr...@gmail.com ] > > Sent: Tuesday, October 20, 2015 8:22 PM > > To: qemu-devel@nongnu.org > >

[Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500

2015-10-20 Thread Shlomo Pongratz
From: Shlomo Pongratz Add virt-v3 machine that uses GIC-500. Registers the CPU system instructions and bind them to the GIC. Pass the cores' affinity to the GIC. Signed-off-by: Shlomo Pongratz --- hw/arm/virt.c | 87