Re: [Qemu-devel] [PATCH RFC v2 14/47] qapi-tests: New tests for union, alternate command arguments

2015-07-31 Thread Markus Armbruster
Eric Blake writes: > On 07/21/2015 06:43 AM, Eric Blake wrote: >> On 07/01/2015 02:22 PM, Markus Armbruster wrote: >>> A command's 'data' must be a struct type, given either as a >>> dictionary, or as struct type name. >>> >>> Existing test case data-int.json covers simple type 'int'. Add test >

Re: [Qemu-devel] [PATCH RFC v2 14/47] qapi-tests: New tests for union, alternate command arguments

2015-07-27 Thread Eric Blake
On 07/27/2015 01:50 AM, Markus Armbruster wrote: >>> This, on the other hand, seems valid from the wire format (it will >>> always be a dictionary). I guess the problem is that we generate a C >>> function signature based by calling out each member of the dictionary - >>> but how do you do that f

Re: [Qemu-devel] [PATCH RFC v2 14/47] qapi-tests: New tests for union, alternate command arguments

2015-07-27 Thread Markus Armbruster
Eric Blake writes: > On 07/21/2015 06:43 AM, Eric Blake wrote: >> On 07/01/2015 02:22 PM, Markus Armbruster wrote: >>> A command's 'data' must be a struct type, given either as a >>> dictionary, or as struct type name. >>> >>> Existing test case data-int.json covers simple type 'int'. Add test >

Re: [Qemu-devel] [PATCH RFC v2 14/47] qapi-tests: New tests for union, alternate command arguments

2015-07-23 Thread Eric Blake
On 07/21/2015 06:43 AM, Eric Blake wrote: > On 07/01/2015 02:22 PM, Markus Armbruster wrote: >> A command's 'data' must be a struct type, given either as a >> dictionary, or as struct type name. >> >> Existing test case data-int.json covers simple type 'int'. Add test >> cases for type names refer

Re: [Qemu-devel] [PATCH RFC v2 14/47] qapi-tests: New tests for union, alternate command arguments

2015-07-21 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: > A command's 'data' must be a struct type, given either as a > dictionary, or as struct type name. > > Existing test case data-int.json covers simple type 'int'. Add test > cases for type names referring to union and alternate types. We could pro

[Qemu-devel] [PATCH RFC v2 14/47] qapi-tests: New tests for union, alternate command arguments

2015-07-01 Thread Markus Armbruster
A command's 'data' must be a struct type, given either as a dictionary, or as struct type name. Existing test case data-int.json covers simple type 'int'. Add test cases for type names referring to union and alternate types. The latter is caught (good), but the former is not (bug). Signed-off-b