Re: [Qemu-devel] [PATCH RFC v2 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-08-02 Thread Christian Borntraeger
On 02.08.19 13:40, Igor Mammedov wrote: > On Fri, 2 Aug 2019 12:27:50 +0200 > Christian Borntraeger wrote: > >> On 02.08.19 12:25, David Hildenbrand wrote: >>> On 02.08.19 11:38, Igor Mammedov wrote: s390 was trying to solve limited KVM memslot size issue by abusing

Re: [Qemu-devel] [PATCH RFC v2 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-08-02 Thread Igor Mammedov
On Fri, 2 Aug 2019 12:27:50 +0200 Christian Borntraeger wrote: > On 02.08.19 12:25, David Hildenbrand wrote: > > On 02.08.19 11:38, Igor Mammedov wrote: > >> s390 was trying to solve limited KVM memslot size issue by abusing > >> memory_region_allocate_system_memory(), which breaks API

Re: [Qemu-devel] [PATCH RFC v2 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-08-02 Thread Christian Borntraeger
On 02.08.19 12:25, David Hildenbrand wrote: > On 02.08.19 11:38, Igor Mammedov wrote: >> s390 was trying to solve limited KVM memslot size issue by abusing >> memory_region_allocate_system_memory(), which breaks API contract >> where the function might be called only once. >> >> s390 should

Re: [Qemu-devel] [PATCH RFC v2 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-08-02 Thread David Hildenbrand
On 02.08.19 11:38, Igor Mammedov wrote: > s390 was trying to solve limited KVM memslot size issue by abusing > memory_region_allocate_system_memory(), which breaks API contract > where the function might be called only once. > > s390 should have used memory aliases to fragment inital memory into

[Qemu-devel] [PATCH RFC v2 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-08-02 Thread Igor Mammedov
s390 was trying to solve limited KVM memslot size issue by abusing memory_region_allocate_system_memory(), which breaks API contract where the function might be called only once. s390 should have used memory aliases to fragment inital memory into smaller chunks to satisfy KVM's memslot