Re: [Qemu-devel] [PATCH RFC v2 4/5] migration: remove unused &local_err parameter in multifd_save_cleanup

2018-11-29 Thread Fei Li
On 11/29/2018 10:50 PM, Philippe Mathieu-Daudé wrote: On 29/11/18 11:03, Fei Li wrote: Always call migrate_set_error() to set the error state without relying on whether multifd_save_cleanup() succeeds. As the passed &local_err is never used in multifd_save_cleanup(), remove it. And make the

Re: [Qemu-devel] [PATCH RFC v2 4/5] migration: remove unused &local_err parameter in multifd_save_cleanup

2018-11-29 Thread Philippe Mathieu-Daudé
On 29/11/18 11:03, Fei Li wrote: > Always call migrate_set_error() to set the error state without relying > on whether multifd_save_cleanup() succeeds. As the passed &local_err > is never used in multifd_save_cleanup(), remove it. And make the > function be: void multifd_save_cleanup(void). Readi

Re: [Qemu-devel] [PATCH RFC v2 4/5] migration: remove unused &local_err parameter in multifd_save_cleanup

2018-11-29 Thread Philippe Mathieu-Daudé
On Thu, Nov 29, 2018 at 3:50 PM Philippe Mathieu-Daudé wrote: > On 29/11/18 11:03, Fei Li wrote: > > Always call migrate_set_error() to set the error state without relying > > on whether multifd_save_cleanup() succeeds. As the passed &local_err > > is never used in multifd_save_cleanup(), remove

[Qemu-devel] [PATCH RFC v2 4/5] migration: remove unused &local_err parameter in multifd_save_cleanup

2018-11-29 Thread Fei Li
Always call migrate_set_error() to set the error state without relying on whether multifd_save_cleanup() succeeds. As the passed &local_err is never used in multifd_save_cleanup(), remove it. And make the function be: void multifd_save_cleanup(void). Signed-off-by: Fei Li Reviewed-by: Juan Quint