Markus Armbruster arm...@redhat.com writes:
Eric Blake ebl...@redhat.com writes:
On 07/29/2015 03:19 AM, Markus Armbruster wrote:
Longest line is a bit over 4KiB for me.
If we break up string literals, at least use some indentation to make it
obvious that multiple lines merge to a single
Eric Blake ebl...@redhat.com writes:
On 07/29/2015 03:19 AM, Markus Armbruster wrote:
Longest line is a bit over 4KiB for me.
If we break up string literals, at least use some indentation to make it
obvious that multiple lines merge to a single array entry. For example
(after patch 47):
On 07/29/2015 03:19 AM, Markus Armbruster wrote:
Longest line is a bit over 4KiB for me.
If we break up string literals, at least use some indentation to make it
obvious that multiple lines merge to a single array entry. For example
(after patch 47):
...
{ 'name': ':abr', 'meta-type':
Eric Blake ebl...@redhat.com writes:
On 07/28/2015 08:33 AM, Markus Armbruster wrote:
Eric Blake ebl...@redhat.com writes:
On 07/01/2015 02:22 PM, Markus Armbruster wrote:
Caution, rough edges.
No joke. It doesn't even compile without this fixup to a rebase snafu
(see [0] below):
Uh,
Eric Blake ebl...@redhat.com writes:
On 07/01/2015 02:22 PM, Markus Armbruster wrote:
Caution, rough edges.
No joke. It doesn't even compile without this fixup to a rebase snafu
(see [0] below):
Uh, how did that happen? I compiled it a million times... (except for
the last time,
On 07/28/2015 08:33 AM, Markus Armbruster wrote:
Eric Blake ebl...@redhat.com writes:
On 07/01/2015 02:22 PM, Markus Armbruster wrote:
Caution, rough edges.
No joke. It doesn't even compile without this fixup to a rebase snafu
(see [0] below):
Uh, how did that happen? I compiled it a
On 07/01/2015 02:22 PM, Markus Armbruster wrote:
Caution, rough edges.
No joke. It doesn't even compile without this fixup to a rebase snafu
(see [0] below):
diff --git i/scripts/qapi-types.py w/scripts/qapi-types.py
index 79e8d24..12f3767 100644
--- i/scripts/qapi-types.py
+++
Caution, rough edges.
qapi/introspect.json defines the introspection schema. It should do
for uses other than QMP.
FIXME it's almost entirely devoid of comments.
The introspection schema does not reflect all the rules and
restrictions that apply to QAPI schemata. A valid QAPI schema has an
