Re: [Qemu-devel] [PATCH RFC v20 5/8] target/avr: Add instruction translation

2019-06-03 Thread Michael Rolnik
Got it. Thanks for the explanation Sent from my cell phone, please ignore typos On Mon, Jun 3, 2019, 6:31 PM Richard Henderson wrote: > On 6/1/19 10:44 PM, Michael Rolnik wrote: > > Hi Richard. > > > > these instructions are not branches or jumps they all do skip. > > Of course they're not all

Re: [Qemu-devel] [PATCH RFC v20 5/8] target/avr: Add instruction translation

2019-06-03 Thread Richard Henderson
On 6/1/19 10:44 PM, Michael Rolnik wrote: > Hi Richard. > > these instructions are not branches or jumps they all do skip. Of course they're not all branches. I used the example of a branch to show a situation in which your translation is wrong. > however, if you think it's important I change i

Re: [Qemu-devel] [PATCH RFC v20 5/8] target/avr: Add instruction translation

2019-06-01 Thread Michael Rolnik
Hi Richard. these instructions are not branches or jumps they all do skip. however, if you think it's important I change it, I will, just show me an example or explain. On Fri, May 31, 2019 at 6:31 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 5/30/19 2:07 PM, Michael Rolnik w

Re: [Qemu-devel] [PATCH RFC v20 5/8] target/avr: Add instruction translation

2019-05-31 Thread Richard Henderson
On 5/30/19 2:07 PM, Michael Rolnik wrote: > +/* decode first instruction */ > +ctx.inst[0].cpc = pc_start; > +decode_opc(&ctx, &ctx.inst[0]); > +do { > +/* set curr/next PCs */ > +cpc = ctx.inst[0].cpc; > +npc = ctx.inst[0].npc; > + > +/* decode next

[Qemu-devel] [PATCH RFC v20 5/8] target/avr: Add instruction translation

2019-05-30 Thread Michael Rolnik
From: Sarah Harris This includes: - TCG translations for each instruction Signed-off-by: Sarah Harris Signed-off-by: Michael Rolnik --- target/avr/translate.c | 2981 1 file changed, 2981 insertions(+) create mode 100644 target/avr/translate.c diff -