Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

2015-02-25 Thread Daniel P. Berrange
On Wed, Feb 25, 2015 at 04:21:15PM +0800, zhanghailiang wrote: > On 2015/2/25 1:24, Daniel P. Berrange wrote: > >On Tue, Feb 24, 2015 at 09:30:56AM -0700, Eric Blake wrote: > >>On 02/24/2015 02:50 AM, Wen Congyang wrote: > Script files are in general very hard to secure. Libvirt marks any > >>

Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

2015-02-25 Thread zhanghailiang
On 2015/2/25 1:24, Daniel P. Berrange wrote: On Tue, Feb 24, 2015 at 09:30:56AM -0700, Eric Blake wrote: On 02/24/2015 02:50 AM, Wen Congyang wrote: Script files are in general very hard to secure. Libvirt marks any domain that uses a script file for controlling networking as tainted, because

Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

2015-02-24 Thread zhanghailiang
On 2015/2/17 7:50, Eric Blake wrote: On 02/11/2015 08:17 PM, zhanghailiang wrote: The 'colo_nicname' should be assigned with network name, for exmple, 'eth2'. It will be parameter of 'colo_script', s/exmple/example/ 'colo_script' should be assigned with an scirpt path. s/an scirpt/a script

Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

2015-02-24 Thread Daniel P. Berrange
On Tue, Feb 24, 2015 at 09:30:56AM -0700, Eric Blake wrote: > On 02/24/2015 02:50 AM, Wen Congyang wrote: > >> Script files are in general very hard to secure. Libvirt marks any > >> domain that uses a script file for controlling networking as tainted, > >> because it cannot guarantee that the scr

Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

2015-02-24 Thread Eric Blake
On 02/24/2015 02:50 AM, Wen Congyang wrote: >> Script files are in general very hard to secure. Libvirt marks any >> domain that uses a script file for controlling networking as tainted, >> because it cannot guarantee that the script did not do arbitrary >> actions. Can you come up with any bette

Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

2015-02-24 Thread Wen Congyang
On 02/17/2015 07:50 AM, Eric Blake wrote: > On 02/11/2015 08:17 PM, zhanghailiang wrote: >> The 'colo_nicname' should be assigned with network name, >> for exmple, 'eth2'. It will be parameter of 'colo_script', > > s/exmple/example/ > >> 'colo_script' should be assigned with an scirpt path. > >

Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

2015-02-16 Thread Eric Blake
On 02/11/2015 08:17 PM, zhanghailiang wrote: > The 'colo_nicname' should be assigned with network name, > for exmple, 'eth2'. It will be parameter of 'colo_script', s/exmple/example/ > 'colo_script' should be assigned with an scirpt path. s/an scirpt/a script/ > > We parse these parameter in t

[Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

2015-02-11 Thread zhanghailiang
The 'colo_nicname' should be assigned with network name, for exmple, 'eth2'. It will be parameter of 'colo_script', 'colo_script' should be assigned with an scirpt path. We parse these parameter in tap. Signed-off-by: zhanghailiang Signed-off-by: Gao feng Signed-off-by: Li Zhijian --- include