Re: [Qemu-devel] [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1

2015-01-21 Thread David Gibson
On Thu, Dec 11, 2014 at 02:25:14PM +0100, Cornelia Huck wrote: > For virtio-1 devices, the driver must not attempt to set feature bits > after it set FEATURES_OK in the device status. Simply reject it in > that case. > > Signed-off-by: Cornelia Huck Reviewed-by: David Gibson -- David Gibson

Re: [Qemu-devel] [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1

2015-01-20 Thread Stefan Hajnoczi
On Fri, Dec 12, 2014 at 12:25:47PM +0100, Thomas Huth wrote: > On Fri, 12 Dec 2014 12:18:25 +0100 > Cornelia Huck wrote: > > > On Fri, 12 Dec 2014 11:55:38 +0100 > > Thomas Huth wrote: > > > > > On Thu, 11 Dec 2014 14:25:14 +0100 > > > Cornelia Huck wrote: > > > > > > > For virtio-1 devices,

Re: [Qemu-devel] [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1

2014-12-12 Thread Thomas Huth
On Fri, 12 Dec 2014 12:18:25 +0100 Cornelia Huck wrote: > On Fri, 12 Dec 2014 11:55:38 +0100 > Thomas Huth wrote: > > > On Thu, 11 Dec 2014 14:25:14 +0100 > > Cornelia Huck wrote: > > > > > For virtio-1 devices, the driver must not attempt to set feature bits > > > after it set FEATURES_OK in

Re: [Qemu-devel] [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1

2014-12-12 Thread Cornelia Huck
On Fri, 12 Dec 2014 11:55:38 +0100 Thomas Huth wrote: > On Thu, 11 Dec 2014 14:25:14 +0100 > Cornelia Huck wrote: > > > For virtio-1 devices, the driver must not attempt to set feature bits > > after it set FEATURES_OK in the device status. Simply reject it in > > that case. > > > > Signed-off

Re: [Qemu-devel] [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1

2014-12-12 Thread Thomas Huth
On Thu, 11 Dec 2014 14:25:14 +0100 Cornelia Huck wrote: > For virtio-1 devices, the driver must not attempt to set feature bits > after it set FEATURES_OK in the device status. Simply reject it in > that case. > > Signed-off-by: Cornelia Huck > --- > hw/virtio/virtio.c | 16 +

[Qemu-devel] [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1

2014-12-11 Thread Cornelia Huck
For virtio-1 devices, the driver must not attempt to set feature bits after it set FEATURES_OK in the device status. Simply reject it in that case. Signed-off-by: Cornelia Huck --- hw/virtio/virtio.c | 16 ++-- include/hw/virtio/virtio.h |2 ++ 2 files changed, 16 inser