Re: [Qemu-devel] [PATCH RFC v6 6/7] migration: fix some error handling

2018-10-31 Thread Fei Li
On 11/01/2018 12:30 AM, Dr. David Alan Gilbert wrote: * Fei Li (f...@suse.com) wrote: On 10/31/2018 03:49 AM, Dr. David Alan Gilbert wrote: * Fei Li (f...@suse.com) wrote: Add error handling for qemu_ram_foreach_migratable_block() when it fails. Always call migrate_set_error() to set the

Re: [Qemu-devel] [PATCH RFC v6 6/7] migration: fix some error handling

2018-10-31 Thread Dr. David Alan Gilbert
* Fei Li (f...@suse.com) wrote: > > > On 10/31/2018 03:49 AM, Dr. David Alan Gilbert wrote: > > * Fei Li (f...@suse.com) wrote: > > > Add error handling for qemu_ram_foreach_migratable_block() when > > > it fails. > > > > > > Always call migrate_set_error() to set the error state without relying

Re: [Qemu-devel] [PATCH RFC v6 6/7] migration: fix some error handling

2018-10-31 Thread Fei Li
On 10/31/2018 03:49 AM, Dr. David Alan Gilbert wrote: * Fei Li (f...@suse.com) wrote: Add error handling for qemu_ram_foreach_migratable_block() when it fails. Always call migrate_set_error() to set the error state without relying on whether multifd_save_cleanup() succeeds. As the passed &lo

Re: [Qemu-devel] [PATCH RFC v6 6/7] migration: fix some error handling

2018-10-30 Thread Dr. David Alan Gilbert
* Fei Li (f...@suse.com) wrote: > Add error handling for qemu_ram_foreach_migratable_block() when > it fails. > > Always call migrate_set_error() to set the error state without relying > on whether multifd_save_cleanup() succeeds. As the passed &local_err > is never used in multifd_save_cleanup(),

[Qemu-devel] [PATCH RFC v6 6/7] migration: fix some error handling

2018-10-29 Thread Fei Li
Add error handling for qemu_ram_foreach_migratable_block() when it fails. Always call migrate_set_error() to set the error state without relying on whether multifd_save_cleanup() succeeds. As the passed &local_err is never used in multifd_save_cleanup(), remove it. Signed-off-by: Fei Li --- mig