Re: [Qemu-devel] [PATCH RFC v7 4/9] migration: fix some segmentation faults when using multifd

2018-11-01 Thread Fei Li
On 11/02/2018 10:31 AM, Peter Xu wrote: On Thu, Nov 01, 2018 at 06:17:10PM +0800, Fei Li wrote: When multifd is used during migration, a segmentaion fault will occur in the source when multifd_save_cleanup() is called again if the multifd_send_state has been freed in earlier error handling. T

Re: [Qemu-devel] [PATCH RFC v7 4/9] migration: fix some segmentation faults when using multifd

2018-11-01 Thread Peter Xu
On Thu, Nov 01, 2018 at 06:17:10PM +0800, Fei Li wrote: > When multifd is used during migration, a segmentaion fault will > occur in the source when multifd_save_cleanup() is called again if > the multifd_send_state has been freed in earlier error handling. This > can happen when migrate_fd_connect

[Qemu-devel] [PATCH RFC v7 4/9] migration: fix some segmentation faults when using multifd

2018-11-01 Thread Fei Li
When multifd is used during migration, a segmentaion fault will occur in the source when multifd_save_cleanup() is called again if the multifd_send_state has been freed in earlier error handling. This can happen when migrate_fd_connect() fails and multifd_fd_cleanup() is called, and then multifd_ne