Re: [Qemu-devel] [PATCH RFC v8 12/12] hw/registerfields.h: Add 8bit and 16bit register macros.

2019-05-05 Thread Alex Bennée
Richard Henderson writes: > On 5/3/19 8:27 AM, Alex Bennée wrote: >> >> Yoshinori Sato writes: >> >>> Some RX peripheral using 8bit and 16bit registers. >>> Added 8bit and 16bit APIs. >> >> Doesn't this mean the build breaks at some point? Features used by other >> patches should be introduced

Re: [Qemu-devel] [PATCH RFC v8 12/12] hw/registerfields.h: Add 8bit and 16bit register macros.

2019-05-05 Thread Yoshinori Sato
On Sat, 04 May 2019 00:27:29 +0900, Alex Bennée wrote: > > > Yoshinori Sato writes: > > > Some RX peripheral using 8bit and 16bit registers. > > Added 8bit and 16bit APIs. > > Doesn't this mean the build breaks at some point? Features used by other > patches should be introduced first so the b

Re: [Qemu-devel] [PATCH RFC v8 12/12] hw/registerfields.h: Add 8bit and 16bit register macros.

2019-05-03 Thread Richard Henderson
On 5/3/19 8:27 AM, Alex Bennée wrote: > > Yoshinori Sato writes: > >> Some RX peripheral using 8bit and 16bit registers. >> Added 8bit and 16bit APIs. > > Doesn't this mean the build breaks at some point? Features used by other > patches should be introduced first so the build remains bisectabl

Re: [Qemu-devel] [PATCH RFC v8 12/12] hw/registerfields.h: Add 8bit and 16bit register macros.

2019-05-03 Thread Alex Bennée
Yoshinori Sato writes: > Some RX peripheral using 8bit and 16bit registers. > Added 8bit and 16bit APIs. Doesn't this mean the build breaks at some point? Features used by other patches should be introduced first so the build remains bisectable. > > Signed-off-by: Yoshinori Sato > --- > inc

[Qemu-devel] [PATCH RFC v8 12/12] hw/registerfields.h: Add 8bit and 16bit register macros.

2019-05-02 Thread Yoshinori Sato
Some RX peripheral using 8bit and 16bit registers. Added 8bit and 16bit APIs. Signed-off-by: Yoshinori Sato --- include/hw/registerfields.h | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/include/hw/registerfields.h b/include/hw/registerfields.h i