Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Gerd Hoffmann
Hi, pty looks like another non-trivial challenge. How does libvirt gather the pty device today? IIRC there is some stderr parsing? Or was it info chardev? With QMP we probably want switch to a more sane model here ... Yes, these days we use info chardev, or query-chardev as

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Daniel P. Berrange
On Fri, Dec 21, 2012 at 10:01:46AM +0100, Gerd Hoffmann wrote: Hi, pty looks like another non-trivial challenge. How does libvirt gather the pty device today? IIRC there is some stderr parsing? Or was it info chardev? With QMP we probably want switch to a more sane model here ...

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Gerd Hoffmann
On 12/20/12 14:02, Gerd Hoffmann wrote: Hi, /me wades through the socket code (unix+tcp) right now, which needs some refactoring to make it fly. Sneak preview attached. Goes on top of the series. Compile tested only so far. Now that it comes to testing: how does the union look (in

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Paolo Bonzini
Il 21/12/2012 12:45, Gerd Hoffmann ha scritto: On 12/20/12 14:02, Gerd Hoffmann wrote: Hi, /me wades through the socket code (unix+tcp) right now, which needs some refactoring to make it fly. Sneak preview attached. Goes on top of the series. Compile tested only so far. Now that it

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Gerd Hoffmann
On 12/21/12 12:53, Paolo Bonzini wrote: Il 21/12/2012 12:45, Gerd Hoffmann ha scritto: On 12/20/12 14:02, Gerd Hoffmann wrote: Hi, /me wades through the socket code (unix+tcp) right now, which needs some refactoring to make it fly. Sneak preview attached. Goes on top of the series.

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Paolo Bonzini
Il 21/12/2012 13:17, Gerd Hoffmann ha scritto: { 'type': 'ChardevDummy', 'data': { } } { 'union': 'ChardevBackend', 'data': { 'file' : 'ChardevFile', 'port' : 'ChardevPort', 'socket' : 'ChardevSocket',

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Gerd Hoffmann
Hi, ... and can't see what is wrong there ... Me neither, but this quick test seems to work here: Test works for me too. Bug turned out to be elsewhere: args_type in qmp-commands.hx not set correctly ... cheers, Gerd

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-20 Thread Michal Privoznik
On 19.12.2012 16:58, Gerd Hoffmann wrote: Hi, Chardev hotplug patch series reloaded. Not finished yet, commit messages not finalized yet, totally untested other than building on linux+windows. I doubt I manage to finish (and test!) it before xmas. Nevertheless I wanna get the bits

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-20 Thread Daniel P. Berrange
On Thu, Dec 20, 2012 at 11:49:29AM +0100, Michal Privoznik wrote: On 19.12.2012 16:58, Gerd Hoffmann wrote: Hi, Chardev hotplug patch series reloaded. Not finished yet, commit messages not finalized yet, totally untested other than building on linux+windows. I doubt I manage to

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-20 Thread Paolo Bonzini
Il 20/12/2012 11:56, Daniel P. Berrange ha scritto: On Thu, Dec 20, 2012 at 11:49:29AM +0100, Michal Privoznik wrote: On 19.12.2012 16:58, Gerd Hoffmann wrote: Hi, Chardev hotplug patch series reloaded. Not finished yet, commit messages not finalized yet, totally untested other than

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-20 Thread Gerd Hoffmann
I doubt I manage to finish (and test!) it before xmas. ^ Okay, the QMP interface seems sane to me (from libvirt POV). However, what about other chardev types like pipe and vc? And I guess pty can be covered by tty, right? I think

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-20 Thread Gerd Hoffmann
Hi, /me wades through the socket code (unix+tcp) right now, which needs some refactoring to make it fly. Sneak preview attached. Goes on top of the series. Compile tested only so far. enjoy, Gerd From 2c5568c20d97d497b43c9af1c1c1388db089c1e9 Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-20 Thread Daniel P. Berrange
On Thu, Dec 20, 2012 at 12:45:33PM +0100, Gerd Hoffmann wrote: I doubt I manage to finish (and test!) it before xmas. ^ Okay, the QMP interface seems sane to me (from libvirt POV). However, what about other chardev types like pipe

[Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-19 Thread Gerd Hoffmann
Hi, Chardev hotplug patch series reloaded. Not finished yet, commit messages not finalized yet, totally untested other than building on linux+windows. I doubt I manage to finish (and test!) it before xmas. Nevertheless I wanna get the bits out of the door for you to see what is coming and