Re: [Qemu-devel] [PATCH STABLE] build: Move QEMU_INCLUDES before QEMU_CFLAGS

2011-08-12 Thread Anthony Liguori
On 08/10/2011 05:04 AM, Jiri Denemark wrote: This patch fixes build when any of the include paths from QEMU_CFLAGS contains a header file with similar name to a header file in qemu sources. I hit it with error.h included by qapi/qapi-types-core.h. GCC decided to use /usr/include/alsa/error.h

[Qemu-devel] [PATCH STABLE] build: Move QEMU_INCLUDES before QEMU_CFLAGS

2011-08-10 Thread Jiri Denemark
This patch fixes build when any of the include paths from QEMU_CFLAGS contains a header file with similar name to a header file in qemu sources. I hit it with error.h included by qapi/qapi-types-core.h. GCC decided to use /usr/include/alsa/error.h instead of qemu's error.h. Signed-off-by: Jiri

Re: [Qemu-devel] [PATCH STABLE] build: Move QEMU_INCLUDES before QEMU_CFLAGS

2011-08-10 Thread Michael Roth
On 08/10/2011 05:04 AM, Jiri Denemark wrote: This patch fixes build when any of the include paths from QEMU_CFLAGS contains a header file with similar name to a header file in qemu sources. I hit it with error.h included by qapi/qapi-types-core.h. GCC decided to use /usr/include/alsa/error.h

Re: [Qemu-devel] [PATCH STABLE] build: Move QEMU_INCLUDES before QEMU_CFLAGS

2011-08-10 Thread Avi Kivity
On 08/10/2011 01:04 PM, Jiri Denemark wrote: This patch fixes build when any of the include paths from QEMU_CFLAGS contains a header file with similar name to a header file in qemu sources. I hit it with error.h included by qapi/qapi-types-core.h. GCC decided to use /usr/include/alsa/error.h

Re: [Qemu-devel] [PATCH STABLE] build: Move QEMU_INCLUDES before QEMU_CFLAGS

2011-08-10 Thread Jiri Denemark
On Wed, Aug 10, 2011 at 16:04:15 +0300, Avi Kivity wrote: On 08/10/2011 01:04 PM, Jiri Denemark wrote: This patch fixes build when any of the include paths from QEMU_CFLAGS contains a header file with similar name to a header file in qemu sources. I hit it with error.h included by

Re: [Qemu-devel] [PATCH STABLE] build: Move QEMU_INCLUDES before QEMU_CFLAGS

2011-08-10 Thread Avi Kivity
On 08/10/2011 05:02 PM, Jiri Denemark wrote: Shouldn't we use -isystem instead of -I for system headers? That would be ideal but unfortunately QEMU_CFLAGS also contains output of pkg-config --cflags which uses -I for header paths. We would need to convert them to -isystem. And is -isystem