Re: [Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-07-16 Thread Ian Main
On Mon, Jul 15, 2013 at 10:47:25PM +0200, Paolo Bonzini wrote: Il 15/07/2013 19:49, Ian Main ha scritto: OK well, I'll explain here my understanding. I apologize if I explain more than needed but it might be good to get this out there anyway. No problem, it's better to be verbose than to

Re: [Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-07-15 Thread Paolo Bonzini
Il 08/07/2013 11:21, Fam Zheng ha scritto: Should the source be bs for MIRROR_SYNC_MODE_NONE? Also in this case you may want to default the format to qcow2 instead of bs's format. Maybe not. source only affects when sync=top below here. For reading the uncopied for target from source, we

Re: [Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-07-15 Thread Ian Main
On Mon, Jul 15, 2013 at 12:50:39PM +0200, Paolo Bonzini wrote: Il 08/07/2013 11:21, Fam Zheng ha scritto: Should the source be bs for MIRROR_SYNC_MODE_NONE? Also in this case you may want to default the format to qcow2 instead of bs's format. Maybe not. source only affects when

Re: [Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-07-15 Thread Paolo Bonzini
Il 15/07/2013 19:49, Ian Main ha scritto: OK well, I'll explain here my understanding. I apologize if I explain more than needed but it might be good to get this out there anyway. No problem, it's better to be verbose than to have an extra iteration. When we do the create with:

Re: [Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-07-08 Thread Fam Zheng
On Mon, 07/01 14:16, Paolo Bonzini wrote: Il 28/06/2013 04:28, Ian Main ha scritto: diff --git a/blockdev.c b/blockdev.c index c5abd65..000dea6 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1430,17 +1430,13 @@ void qmp_drive_backup(const char *device, const char *target,

Re: [Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-07-04 Thread Paolo Bonzini
Il 03/07/2013 20:14, Ian Main ha scritto: Should the source be bs for MIRROR_SYNC_MODE_NONE? Also in this case you may want to default the format to qcow2 instead of bs's format. I'm not sure that it matters what the source is for NONE. Since we are copying all new writes, whether they

Re: [Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-07-03 Thread Ian Main
On Mon, Jul 01, 2013 at 02:16:12PM +0200, Paolo Bonzini wrote: Il 28/06/2013 04:28, Ian Main ha scritto: This patch adds sync-modes to the drive-backup interface and implements the FULL, NONE and TOP modes of synchronization. FULL performs as before copying the entire contents of the

Re: [Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-07-01 Thread Paolo Bonzini
Il 28/06/2013 04:28, Ian Main ha scritto: This patch adds sync-modes to the drive-backup interface and implements the FULL, NONE and TOP modes of synchronization. FULL performs as before copying the entire contents of the drive while preserving the point-in-time using CoW. NONE only copies

[Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-06-27 Thread Ian Main
This patch adds sync-modes to the drive-backup interface and implements the FULL, NONE and TOP modes of synchronization. FULL performs as before copying the entire contents of the drive while preserving the point-in-time using CoW. NONE only copies new writes to the target drive. TOP copies